From: Dave Chinner <david@fromorbit.com>
To: wzt.wzt@gmail.com
Cc: linux-kernel@vger.kernel.org, xfs-masters@oss.sgi.com, aelder@sgi.com
Subject: Re: [PATCH] xfs: Fix integer overflow in fs/xfs/linux-2.6/xfs_ioctl*.c
Date: Thu, 25 Mar 2010 08:54:36 +1100 [thread overview]
Message-ID: <20100324215436.GC7671@dastard> (raw)
In-Reply-To: <20100317031947.GB2796@localhost.localdomain>
On Wed, Mar 17, 2010 at 11:19:47AM +0800, wzt.wzt@gmail.com wrote:
> The am_hreq.opcount field in the xfs_attrmulti_by_handle() interface
> is not bounded correctly. The opcount is used to determine the size
> of the buffer required. The size is bounded, but can overflow and so
> the size checks may not be sufficient to catch invalid opcounts.
> Fix it by catching opcount values that would cause overflows before
> calculating the size.
>
> Signed-off-by: Zhitong Wang <zhitong.wangzt@alibaba-inc.com>
Looks good now. I'll queue it up with all the other pending changes
I have.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2010-03-24 21:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-17 3:19 [PATCH] xfs: Fix integer overflow in fs/xfs/linux-2.6/xfs_ioctl*.c wzt.wzt
2010-03-24 21:54 ` Dave Chinner [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-03-16 15:53 wzt.wzt
2010-03-17 2:41 ` Dave Chinner
2010-03-17 3:00 ` wzt wzt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100324215436.GC7671@dastard \
--to=david@fromorbit.com \
--cc=aelder@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=wzt.wzt@gmail.com \
--cc=xfs-masters@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox