From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Jean Delvare <khali@linux-fr.org>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>,
linux-pm@lists.linux-foundation.org,
Linux I2C <linux-i2c@vger.kernel.org>,
Alan Stern <stern@rowland.harvard.edu>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] i2c: Fix bus-level power management callbacks
Date: Thu, 25 Mar 2010 09:28:02 +0000 [thread overview]
Message-ID: <20100325092802.GA27729@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <20100325095720.0b115056@hyperion.delvare>
On Thu, Mar 25, 2010 at 09:57:20AM +0100, Jean Delvare wrote:
> Mark, you contributed the initial runtime PM support for the i2c
> subsystem, I thought you would have comments on Rafael's
> reimplementation?
Yeah, see below...
> > drivers/i2c/i2c-core.c | 168 ++++++++++++++++++++++++++-------------------
> > include/linux/pm_runtime.h | 7 +
> I am a little surprised to see changes to a generic header file here,
> how is the i2c subsystem so special that we have needs other subsystems
> did not?
Very few subsystems actually support runtime PM thus far - I think it's
more the case that I2C is an early user than anything else.
> Apart from the above, the code looks sane to me, but then again I don't
> know a thing about power management. I'll keep this patch in my i2c
> tree, scheduled for merge in 2.6.35. If there are any updates, please
> send them over, either as a new patch or as incremental changes which I
> will merge myself.
I'm in a similar position - the code looks fine except I'm not 100% sure
I follow all the possible ifdefs and I've never actually used hibernate
(s2disk isn't supported on ARM) but for what it's worth:
Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
next prev parent reply other threads:[~2010-03-25 9:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <201003132204.30905.rjw@sisk.pl>
2010-03-19 22:44 ` [PATCH] i2c: Fix bus-level power management callbacks Rafael J. Wysocki
2010-03-25 8:57 ` Jean Delvare
2010-03-25 9:28 ` Mark Brown [this message]
2010-03-25 20:16 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100325092802.GA27729@rakim.wolfsonmicro.main \
--to=broonie@opensource.wolfsonmicro.com \
--cc=khali@linux-fr.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=rjw@sisk.pl \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox