From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753852Ab0CYMQf (ORCPT ); Thu, 25 Mar 2010 08:16:35 -0400 Received: from moutng.kundenserver.de ([212.227.126.171]:52292 "EHLO moutng.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752573Ab0CYMQe convert rfc822-to-8bit (ORCPT ); Thu, 25 Mar 2010 08:16:34 -0400 From: Karsten Keil Reply-To: isdn@linux-pingi.de To: Henrik Kretzschmar Subject: Re: [PATCH 4/4] isdn: Cleanup Sections in PCMCIA driver elsa Date: Thu, 25 Mar 2010 13:16:21 +0100 User-Agent: KMail/1.12.2 (Linux/2.6.27.45-0.1-default; KDE/4.4.1; x86_64; ; ) Cc: davem@davemloft.net, linux@dominikbrodowski.net, akpm@linux-foundation.org, linux-kernel@vger.kernel.org References: <1269518732-4515-1-git-send-email-henne@nachtwindheim.de> <1269518732-4515-3-git-send-email-henne@nachtwindheim.de> <1269518732-4515-4-git-send-email-henne@nachtwindheim.de> In-Reply-To: <1269518732-4515-4-git-send-email-henne@nachtwindheim.de> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 8BIT Message-Id: <201003251316.21555.isdn@linux-pingi.de> X-Provags-ID: V01U2FsdGVkX18/C0rkRGqPjGVuXeCRjsBkDf21Jb5MEOuyjl6 8XStGjEOYhETz8VQ212VbBz7S79XbOua9LYFGnMN+UkDViKZAD znEHHmKvYAeyDXd/J5rFeb50mF1oGpO Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Donnerstag, 25. März 2010 13:05:32 Henrik Kretzschmar wrote: > Compiling this driver gave a section mismatch, > so I reviewed the init/exit paths of the driver > and made the correct changes. > > WARNING: drivers/isdn/hisax/built-in.o(.text+0x55e37): Section mismatch > in reference from the function elsa_cs_config() to the function > .devinit.text:hisax_init_pcmcia() > The function elsa_cs_config() references > the function __devinit hisax_init_pcmcia(). > This is often because elsa_cs_config lacks a __devinit > annotation or the annotation of hisax_init_pcmcia is wrong. > > Signed-off-by: Henrik Kretzschmar Acked-by: Thank you for fixing this.