From: Pavel Machek <pavel@ucw.cz>
To: Dan Carpenter <error27@gmail.com>,
Shaohua Li <shaohua.li@intel.com>, Len Brown <lenb@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Chen Gong <gong.chen@linux.intel.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] acpi_pad: "processor_aggregator" name too long
Date: Thu, 25 Mar 2010 15:27:38 +0100 [thread overview]
Message-ID: <20100325142738.GD1602@ucw.cz> (raw)
In-Reply-To: <20100319114806.GN5331@bicker>
On Fri 2010-03-19 14:48:06, Dan Carpenter wrote:
> cpi_device_class can only be 19 characters and a NULL terminator.
>
> With the current name we get a buffer overflow in acpi_pad_add()
> strcpy(acpi_device_class(device), ACPI_PROCESSOR_AGGREGATOR_CLASS);
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
> ---
> Feel free to pick your own name if you don't like mine. :)
>
>
> diff --git a/drivers/acpi/acpi_pad.c b/drivers/acpi/acpi_pad.c
> index 7e52295..2db89d9 100644
> --- a/drivers/acpi/acpi_pad.c
> +++ b/drivers/acpi/acpi_pad.c
> @@ -30,7 +30,7 @@
> #include <acpi/acpi_bus.h>
> #include <acpi/acpi_drivers.h>
>
> -#define ACPI_PROCESSOR_AGGREGATOR_CLASS "processor_aggregator"
> +#define ACPI_PROCESSOR_AGGREGATOR_CLASS "proc_aggregator"
Sounds like /proc aggregator to me. "cpu_aggregator"?
> #define ACPI_PROCESSOR_AGGREGATOR_DEVICE_NAME "Processor Aggregator"
> #define ACPI_PROCESSOR_AGGREGATOR_NOTIFY 0x80
> static DEFINE_MUTEX(isolated_cpus_lock);
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2010-03-25 14:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-19 11:48 [patch] acpi_pad: "processor_aggregator" name too long Dan Carpenter
2010-03-19 12:25 ` walter harms
2010-03-25 14:27 ` Pavel Machek [this message]
2010-03-25 14:41 ` [patch v2] " Dan Carpenter
2010-03-25 18:38 ` Pavel Machek
2010-04-06 1:21 ` Shaohua Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100325142738.GD1602@ucw.cz \
--to=pavel@ucw.cz \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=error27@gmail.com \
--cc=gong.chen@linux.intel.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shaohua.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox