From: Jens Axboe <jens.axboe@oracle.com>
To: Divyesh Shah <dpshah@google.com>
Cc: linux-kernel@vger.kernel.org, nauman@google.com, vgoyal@redhat.com
Subject: Re: [PATCH] cfq-iosched: Do not merge queues of BE and IDLE classes
Date: Thu, 25 Mar 2010 15:45:28 +0100 [thread overview]
Message-ID: <20100325144528.GW5768@kernel.dk> (raw)
In-Reply-To: <20100324205127.7477.97997.stgit@austin.mtv.corp.google.com>
On Wed, Mar 24 2010, Divyesh Shah wrote:
> even if they are found to be co-operating.
>
> The prio_trees do not have any IDLE cfqqs on them. cfq_close_cooperator()
> is called from cfq_select_queue() and cfq_completed_request(). The latter
> ensures that the close cooperator code does not get invoked if the current
> cfqq is of class IDLE but the former doesn't seem to have any such checks.
> So an IDLE cfqq may get merged with a BE cfqq from the same group which
> should be avoided.
Thanks, applied.
--
Jens Axboe
prev parent reply other threads:[~2010-03-25 14:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-24 20:52 [PATCH] cfq-iosched: Do not merge queues of BE and IDLE classes Divyesh Shah
2010-03-25 1:08 ` Vivek Goyal
2010-03-25 14:45 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100325144528.GW5768@kernel.dk \
--to=jens.axboe@oracle.com \
--cc=dpshah@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nauman@google.com \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox