From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753912Ab0CYS1K (ORCPT ); Thu, 25 Mar 2010 14:27:10 -0400 Received: from one.firstfloor.org ([213.235.205.2]:54164 "EHLO one.firstfloor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752315Ab0CYS1I (ORCPT ); Thu, 25 Mar 2010 14:27:08 -0400 Date: Thu, 25 Mar 2010 19:27:02 +0100 From: Andi Kleen To: Ingo Molnar Cc: Linus Torvalds , Thomas Gleixner , Andi Kleen , x86@kernel.org, LKML , jesse.brandeburg@intel.com Subject: Re: [PATCH] Prevent nested interrupts when the IRQ stack is near overflowing v2 Message-ID: <20100325182702.GR20695@one.firstfloor.org> References: <20100324190150.GA18803@basil.fritz.box> <20100325003652.GG20695@one.firstfloor.org> <20100325093744.GH20695@one.firstfloor.org> <20100325162737.GA5276@elte.hu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100325162737.GA5276@elte.hu> User-Agent: Mutt/1.4.2.2i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > I think the patch as posted solves a real problem, but also perpetuates a bad > situation. > > At minimum we should print a (one-time) warning that some badness occured. > That would push us either in the direction of improving drivers, or towards > improving the generic code. What should a driver do to prevent that? I don't see what it could do short of castrating itself (like refusing to use multiple ports) As Linus says the driver doesn't know if setting IRQF_DISABLED is safe. -Andi -- ak@linux.intel.com -- Speaking for myself only.