From: Thomas Renninger <trenn@suse.de>
To: Valdis.Kletnieks@vt.edu
Cc: Borislav Petkov <bp@amd64.org>,
akpm@linux-foundation.org, davej@redhat.com,
linux@dominikbrodowski.net, mingo@elte.hu, hpa@zytor.com,
tglx@linutronix.de, cpufreq@vger.kernel.org, x86@kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/5] cpufreq: Add APERF/MPERF support for AMD processors
Date: Thu, 25 Mar 2010 21:59:31 +0100 [thread overview]
Message-ID: <201003252159.31883.trenn@suse.de> (raw)
In-Reply-To: <13218.1269546919@localhost>
On Thursday 25 March 2010 08:55:19 pm Valdis.Kletnieks@vt.edu wrote:
> On Thu, 25 Mar 2010 10:43:04 BST, Thomas Renninger said:
> > > + if (c->cpuid_level >= 6) {
> >
> > and remove this (arch/x86/kernel/cpu/intel.c):
> > if (c->cpuid_level > 6) {
>
> So is > or >= the correct comparator here?
This one: >= is correct (for both).
I double checked, there is one Intel CPU type
having a cpuid_level of 6, but this would not support aperf/mperf, thus
above is still fine.
The remaining question is what Borislav said:
are there other x86 CPU vendors who could use this differently.
I very much expect there are not.
IMO you should resubmit this one or the whole series with this change
and Dave should just push this in his tree and queue it up, there was enough
time to object.
Thanks,
Thomas
next prev parent reply other threads:[~2010-03-25 20:59 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-24 17:46 [PATCH 0/5] powernow-k8: Core Performance Boost and effective frequency support Borislav Petkov
2010-03-24 17:46 ` [PATCH 1/5] x86, cpu: Add AMD core boosting feature flag to /proc/cpuinfo Borislav Petkov
2010-03-24 17:46 ` [PATCH 2/5] powernow-k8: Add core performance boost support Borislav Petkov
2010-03-24 17:46 ` [PATCH 3/5] cpufreq: Add APERF/MPERF support for AMD processors Borislav Petkov
2010-03-25 9:43 ` Thomas Renninger
2010-03-25 11:06 ` Borislav Petkov
2010-03-25 19:55 ` Valdis.Kletnieks
2010-03-25 20:59 ` Thomas Renninger [this message]
2010-03-25 22:16 ` Borislav Petkov
2010-03-24 17:46 ` [PATCH 4/5] powernow-k8: Fix frequency reporting Borislav Petkov
2010-03-24 17:46 ` [PATCH 5/5] cpufreq: Unify sysfs attribute definition macros Borislav Petkov
2010-03-25 9:50 ` [PATCH 0/5] powernow-k8: Core Performance Boost and effective frequency support Thomas Renninger
-- strict thread matches above, loose matches on Subject: below --
2010-03-22 18:38 Borislav Petkov
2010-03-22 18:38 ` [PATCH 3/5] cpufreq: Add APERF/MPERF support for AMD processors Borislav Petkov
2010-03-23 11:26 ` Thomas Renninger
2010-03-23 11:59 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201003252159.31883.trenn@suse.de \
--to=trenn@suse.de \
--cc=Valdis.Kletnieks@vt.edu \
--cc=akpm@linux-foundation.org \
--cc=bp@amd64.org \
--cc=cpufreq@vger.kernel.org \
--cc=davej@redhat.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@dominikbrodowski.net \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox