From: Joel Becker <Joel.Becker@oracle.com>
To: Yinghai Lu <yinghai@kernel.org>
Cc: Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>,
Andrew Morton <akpm@linux-foundation.org>,
David Miller <davem@davemloft.net>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org,
Ian Campbell <ian.campbell@citrix.com>,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH 1/8] x86: do not free zero sized per cpu areas
Date: Thu, 25 Mar 2010 15:29:00 -0700 [thread overview]
Message-ID: <20100325222859.GC9984@mail.oracle.com> (raw)
In-Reply-To: <1269427029-21000-2-git-send-email-yinghai@kernel.org>
On Wed, Mar 24, 2010 at 03:37:02AM -0700, Yinghai Lu wrote:
> From: Ian Campbell <ian.campbell@citrix.com>
>
> This avoids an infinite loop in free_early_partial().
>
> Add a warning to free_early_partial to catch future problems.
>
> -v5: put back start > end back into WARN_ONCE()
> -v6: use one line for if according to linus
>
> Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
> Signed-off-by: Yinghai Lu <yinghai@kernel.org>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Cc: Ingo Molnar <mingo@elte.hu>
Tested-by: Joel Becker <joel.becker@oracle.com>
I ran into this when moving my paravirt_ops PVMs to 2.6.34-rc1.
I turned on CONFIG_NO_BOOTMEM to try it because it was the default. I
had to put earlyprintk=xen on the command line to debug the problem.
My boots hung after:
...
(early) Local APIC disabled by BIOS -- you can enable it with "lapic"
(early) APIC: disable apic facility
(early) APIC: switched to apic NOOP
(early) Allocating PCI resources starting at 78000000 (gap: 78000000:88000000)
(early) Booting paravirtualized kernel on Xen
(early) Xen version: 3.1.3-rc3
(early) setup_percpu: NR_CPUS:8 nr_cpumask_bits:8 nr_cpu_ids:2 nr_node_ids:1
Bisecting narrowed the problem to fb90ef [early_res: Add
free_early_partial()]. Turning off CONFIG_NO_BOOTMEM allowed me to
boot. I then hunted up references to this function, which found me this
patch.
This patch successfully resolved the problem.
Joel
--
"The nice thing about egotists is that they don't talk about other
people."
- Lucille S. Harper
Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker@oracle.com
Phone: (650) 506-8127
next prev parent reply other threads:[~2010-03-25 22:31 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-24 10:37 [PATCH -v4 00/08] use lmb with x86 Yinghai Lu
2010-03-24 10:37 ` [PATCH 1/8] x86: do not free zero sized per cpu areas Yinghai Lu
2010-03-25 22:29 ` Joel Becker [this message]
2010-03-24 10:37 ` [PATCH 2/8] x86: add find_e820_area_node Yinghai Lu
2010-03-24 10:37 ` [PATCH 3/8] x86: add sanitize_e820_map Yinghai Lu
2010-03-24 10:37 ` [PATCH 4/8] lmb: seperate region array from lmb_region struct Yinghai Lu
2010-03-24 10:37 ` [PATCH 5/8] x86: use lmb to replace early_res Yinghai Lu
2010-03-24 10:37 ` [PATCH 6/8] x86: remove find_e820_area Yinghai Lu
2010-03-24 10:37 ` [PATCH 7/8] early_res: prepare for other platform to use it Yinghai Lu
2010-03-24 10:37 ` [PATCH 8/8] powerpc : use early_res/nobootmem Yinghai Lu
2010-03-24 10:48 ` [PATCH -v4 00/08] use lmb with x86 Ingo Molnar
2010-03-24 11:41 ` Michael Ellerman
2010-03-24 18:18 ` Yinghai Lu
2010-03-24 18:31 ` Yinghai Lu
-- strict thread matches above, loose matches on Subject: below --
2010-03-24 10:34 Yinghai Lu
2010-03-24 10:34 ` [PATCH 1/8] x86: do not free zero sized per cpu areas Yinghai Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100325222859.GC9984@mail.oracle.com \
--to=joel.becker@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=davem@davemloft.net \
--cc=hpa@zytor.com \
--cc=ian.campbell@citrix.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox