From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753252Ab0CZRmp (ORCPT ); Fri, 26 Mar 2010 13:42:45 -0400 Received: from rcsinet12.oracle.com ([148.87.113.124]:26885 "EHLO rcsinet12.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750772Ab0CZRmn (ORCPT ); Fri, 26 Mar 2010 13:42:43 -0400 Date: Fri, 26 Mar 2010 10:40:26 -0700 From: Randy Dunlap To: Henrik Kretzschmar , linux-fbdev@vger.kernel.org Cc: Andrew Morton , Krzysztof Helt , Arnaud Patard , Andres Salomon , Jaya Kumar , linux-kernel@vger.kernel.org Subject: Re: [PATCH] Fix section mismatches in virtual framebuffer Message-Id: <20100326104026.5cda2fbf.randy.dunlap@oracle.com> In-Reply-To: <1269433035-6141-1-git-send-email-henne@nachtwindheim.de> References: <1269433035-6141-1-git-send-email-henne@nachtwindheim.de> Organization: Oracle Linux Eng. X-Mailer: Sylpheed 2.7.1 (GTK+ 2.16.6; x86_64-unknown-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Source-IP: acsmt355.oracle.com [141.146.40.155] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A090202.4BACF1F2.0181:SCFMA4539814,ss=1,fgs=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [adding linux-fbdev mailing list] Acked-by: Randy Dunlap On Wed, 24 Mar 2010 13:17:15 +0100 Henrik Kretzschmar wrote: > Both structs, vfb_default and vfb_fix, should not be freed, > since they are referenced and used by the struct fb_info of that device. > > WARNING: drivers/video/vfb.o(.devinit.text+0x13f): Section mismatch in > reference from the function vfb_probe() to the variable > .init.data:vfb_default > The function __devinit vfb_probe() references > a variable __initdata vfb_default. > If vfb_default is only used by vfb_probe then > annotate vfb_default with a matching annotation. > > WARNING: drivers/video/vfb.o(.devinit.text+0x162): Section mismatch in > reference from the function vfb_probe() to the variable > .init.data:vfb_fix > The function __devinit vfb_probe() references > a variable __initdata vfb_fix. > If vfb_fix is only used by vfb_probe then > annotate vfb_fix with a matching annotation. > > WARNING: drivers/video/vfb.o(.devinit.text+0x177): Section mismatch in > reference from the function vfb_probe() to the variable > .init.data:vfb_fix > The function __devinit vfb_probe() references > a variable __initdata vfb_fix. > If vfb_fix is only used by vfb_probe then > annotate vfb_fix with a matching annotation. > > WARNING: drivers/video/vfb.o(.devinit.text+0x184): Section mismatch in > reference from the function vfb_probe() to the (unknown reference) > .init.data:(unknown) > The function __devinit vfb_probe() references > a (unknown reference) __initdata (unknown). > If (unknown) is only used by vfb_probe then > annotate (unknown) with a matching annotation. > > Signed-off-by: Henrik Kretzschmar > --- > drivers/video/vfb.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/video/vfb.c b/drivers/video/vfb.c > index b8ab995..ae5796d 100644 > --- a/drivers/video/vfb.c > +++ b/drivers/video/vfb.c > @@ -79,7 +79,7 @@ static void rvfree(void *mem, unsigned long size) > vfree(mem); > } > > -static struct fb_var_screeninfo vfb_default __initdata = { > +static struct fb_var_screeninfo vfb_default = { > .xres = 640, > .yres = 480, > .xres_virtual = 640, > @@ -101,7 +101,7 @@ static struct fb_var_screeninfo vfb_default __initdata = { > .vmode = FB_VMODE_NONINTERLACED, > }; > > -static struct fb_fix_screeninfo vfb_fix __initdata = { > +static struct fb_fix_screeninfo vfb_fix = { > .id = "Virtual FB", > .type = FB_TYPE_PACKED_PIXELS, > .visual = FB_VISUAL_PSEUDOCOLOR, > -- --- ~Randy