Re: [PATCH] staging: winbond: wb35rx.c Coding style fixes.

[Dan Carpenter <error27@gmail.com>]

On Thu, Mar 25, 2010 at 11:13:59PM +0100, Lars Lindley wrote:
> I fixed checkpatch issues except for long lines and printk:s.
> I also removed version comments and the () in a return statement.
> Generated .o is identical to master and i checked the code with
> Dan Carpenters strip_whitespace.pl and diff.
> 
> Signed-off-by: Lars Lindley <lindley@coyote.org>
> ---

	[ snip ]
  			}
>  
> -			// Start to process Rx buffer
> -//			RxDes.Descriptor_ID = RxBufferId; // Due to synchronous indicate, the field doesn't necessary to use.
> -			BufferSize -= 8; //subtract 8 byte for 35's USB header length
> +			/*
> +			 * Start to process Rx buffer
> +			 * RxDes.Descriptor_ID = RxBufferId;
> +			 * Due to synchronous indicate, the field doesn't
> +			 * necessary to use.
> +			 */
> +			BufferSize -= 8; /* subtract 8 byte for 35's USB header length */

Perhaps something like:

	Wb35Rx_indicate() is called synchronously so it isn't necessary to
	set "RxDes.Descriptor_ID = RxBufferId;"

It's still not totally clear but it's a little bit clearer.

Otherwise, looks good.

Acked-by: Dan Carpenter <error27@gmail.com>

regards,
dan carpenter