[PATCH 01/16] ARM mach-at91: duplicated include

[PATCH 01/16] ARM mach-at91: duplicated include

[Andrea Gelmini]

arch/arm/mach-at91/board-sam9m10g45ek.c: mach/hardware.h is included more than once

Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net>
---
 arch/arm/mach-at91/board-sam9m10g45ek.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/arch/arm/mach-at91/board-sam9m10g45ek.c b/arch/arm/mach-at91/board-sam9m10g45ek.c
index 98f9f4b..ee80059 100644
--- a/arch/arm/mach-at91/board-sam9m10g45ek.c
+++ b/arch/arm/mach-at91/board-sam9m10g45ek.c
@@ -25,7 +25,6 @@
 #include <linux/leds.h>
 #include <linux/clk.h>
 
-#include <mach/hardware.h>
 #include <video/atmel_lcdc.h>
 
 #include <asm/setup.h>
-- 
1.7.0.3.296.g9776a

Re: [PATCH 01/16] ARM mach-at91: duplicated include

[Andrew Victor]

> arch/arm/mach-at91/board-sam9m10g45ek.c: mach/hardware.h is included more than once
>
> Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net>

Acked-by: Andrew Victor <linux@maxim.org.za>

Please submit the patch to Russell King's patch tracking system.

[PATCH 02/16] ARM mach-mx3: duplicated include

[Andrea Gelmini]

arch/arm/mach-mx3/mach-pcm037.c: linux/fsl_devices.h is included more than once.

Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net>
---
 arch/arm/mach-mx3/mach-pcm037.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/arch/arm/mach-mx3/mach-pcm037.c b/arch/arm/mach-mx3/mach-pcm037.c
index 11f5315..a550ae9 100644
--- a/arch/arm/mach-mx3/mach-pcm037.c
+++ b/arch/arm/mach-mx3/mach-pcm037.c
@@ -35,7 +35,6 @@
 #include <linux/can/platform/sja1000.h>
 #include <linux/usb/otg.h>
 #include <linux/usb/ulpi.h>
-#include <linux/fsl_devices.h>
 
 #include <media/soc_camera.h>
 
-- 
1.7.0.3.296.g9776a

[PATCH 03/16] ARM mach-mx3: duplicated include

[Andrea Gelmini]

arch/arm/mach-mx3/mx31lite-db.c: linux/platform_device.h is included more than once.

Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net>
---
 arch/arm/mach-mx3/mx31lite-db.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/arch/arm/mach-mx3/mx31lite-db.c b/arch/arm/mach-mx3/mx31lite-db.c
index ccd8742..16c955e 100644
--- a/arch/arm/mach-mx3/mx31lite-db.c
+++ b/arch/arm/mach-mx3/mx31lite-db.c
@@ -28,7 +28,6 @@
 #include <linux/types.h>
 #include <linux/init.h>
 #include <linux/gpio.h>
-#include <linux/platform_device.h>
 #include <linux/leds.h>
 #include <linux/platform_device.h>
 
-- 
1.7.0.3.296.g9776a

[PATCH 04/16] x86 init_64.c: duplicated include

[Andrea Gelmini]

arch/x86/mm/init_64.c: linux/bootmem.h is included more than once.

Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net>
---
 arch/x86/mm/init_64.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/arch/x86/mm/init_64.c b/arch/x86/mm/init_64.c
index e9b040e..a544bec 100644
--- a/arch/x86/mm/init_64.c
+++ b/arch/x86/mm/init_64.c
@@ -49,7 +49,6 @@
 #include <asm/numa.h>
 #include <asm/cacheflush.h>
 #include <asm/init.h>
-#include <linux/bootmem.h>
 
 static unsigned long dma_reserve __initdata;
 
-- 
1.7.0.3.296.g9776a

[PATCH 05/16] Docs hpet_example.c: duplicated includes

[Andrea Gelmini]

Documentation/timers/hpet_example.c: fcntl.h is included more than once.
Documentation/timers/hpet_example.c: signal.h is included more than once.

Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net>
---
 Documentation/timers/hpet_example.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/Documentation/timers/hpet_example.c b/Documentation/timers/hpet_example.c
index f9ce2d9..4bfafb7 100644
--- a/Documentation/timers/hpet_example.c
+++ b/Documentation/timers/hpet_example.c
@@ -10,7 +10,6 @@
 #include <sys/types.h>
 #include <sys/wait.h>
 #include <signal.h>
-#include <fcntl.h>
 #include <errno.h>
 #include <sys/time.h>
 #include <linux/hpet.h>
@@ -24,7 +23,6 @@ extern void hpet_read(int, const char **);
 
 #include <sys/poll.h>
 #include <sys/ioctl.h>
-#include <signal.h>
 
 struct hpet_command {
 	char		*command;
-- 
1.7.0.3.296.g9776a

[PATCH 06/16] Staging: iio: Documentation/lis3l02dqbuffersimple.c: duplicated include

[Andrea Gelmini]

drivers/staging/iio/Documentation/lis3l02dqbuffersimple.c: dirent.h is included more than once.

Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net>
---
 .../iio/Documentation/lis3l02dqbuffersimple.c      |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/drivers/staging/iio/Documentation/lis3l02dqbuffersimple.c b/drivers/staging/iio/Documentation/lis3l02dqbuffersimple.c
index 2b5cfc5..6a8fa0c 100644
--- a/drivers/staging/iio/Documentation/lis3l02dqbuffersimple.c
+++ b/drivers/staging/iio/Documentation/lis3l02dqbuffersimple.c
@@ -19,7 +19,6 @@
 #include <sys/dir.h>
 
 #include <linux/types.h>
-#include <dirent.h>
 #include "iio_util.h"
 
 static const char *ring_access = "/dev/iio/lis3l02dq_ring_access";
-- 
1.7.0.3.296.g9776a

Re: [PATCH 06/16] Staging: iio: Documentation/lis3l02dqbuffersimple.c: duplicated include

[Jonathan Cameron]

On 03/25/10 17:22, Andrea Gelmini wrote:
> drivers/staging/iio/Documentation/lis3l02dqbuffersimple.c: dirent.h is included more than once.
> 
> Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net>
Fair point.

Acked-by: Jonathan Cameron <jic23@cam.ac.uk>
> ---
>  .../iio/Documentation/lis3l02dqbuffersimple.c      |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/staging/iio/Documentation/lis3l02dqbuffersimple.c b/drivers/staging/iio/Documentation/lis3l02dqbuffersimple.c
> index 2b5cfc5..6a8fa0c 100644
> --- a/drivers/staging/iio/Documentation/lis3l02dqbuffersimple.c
> +++ b/drivers/staging/iio/Documentation/lis3l02dqbuffersimple.c
> @@ -19,7 +19,6 @@
>  #include <sys/dir.h>
>  
>  #include <linux/types.h>
> -#include <dirent.h>
>  #include "iio_util.h"
>  
>  static const char *ring_access = "/dev/iio/lis3l02dq_ring_access";

[PATCH 07/16] Staging: sep: sep_driver.c: duplicated include

[Andrea Gelmini]

drivers/staging/sep/sep_driver.c: linux/sched.h is included more than once.

Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net>
---
 drivers/staging/sep/sep_driver.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/drivers/staging/sep/sep_driver.c b/drivers/staging/sep/sep_driver.c
index 265de79..9be1fb7 100644
--- a/drivers/staging/sep/sep_driver.c
+++ b/drivers/staging/sep/sep_driver.c
@@ -39,7 +39,6 @@
 #include <linux/mm.h>
 #include <linux/poll.h>
 #include <linux/wait.h>
-#include <linux/sched.h>
 #include <linux/pci.h>
 #include <linux/firmware.h>
 #include <asm/ioctl.h>
-- 
1.7.0.3.296.g9776a

Re: [PATCH 07/16] Staging: sep: sep_driver.c: duplicated include

[Randy Dunlap]

On 03/25/10 10:22, Andrea Gelmini wrote:
> drivers/staging/sep/sep_driver.c: linux/sched.h is included more than once.
> 
> Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net>

Hi,

You don't need to be sending these patches to the linux-doc mailing list.
Thanks.

> ---
>  drivers/staging/sep/sep_driver.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/staging/sep/sep_driver.c b/drivers/staging/sep/sep_driver.c
> index 265de79..9be1fb7 100644
> --- a/drivers/staging/sep/sep_driver.c
> +++ b/drivers/staging/sep/sep_driver.c
> @@ -39,7 +39,6 @@
>  #include <linux/mm.h>
>  #include <linux/poll.h>
>  #include <linux/wait.h>
> -#include <linux/sched.h>
>  #include <linux/pci.h>
>  #include <linux/firmware.h>
>  #include <asm/ioctl.h>


-- 
~Randy

Re: [PATCH 07/16] Staging: sep: sep_driver.c: duplicated include

[Andrea Gelmini]

2010/3/25 Randy Dunlap <rdunlap@xenotime.net>:
> Hi,
>
> You don't need to be sending these patches to the linux-doc mailing list.
> Thanks.

Shame on me. I made a mess with bash history...

I'm very sorry,
Andrea

[PATCH 08/16] Staging: wlan-ng: p80211wext.c: duplicated include

[Andrea Gelmini]

drivers/staging/wlan-ng/p80211wext.c: linux/bitops.h is included more than once.

Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net>
---
 drivers/staging/wlan-ng/p80211wext.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/drivers/staging/wlan-ng/p80211wext.c b/drivers/staging/wlan-ng/p80211wext.c
index 2fa1dfa..b6734e7 100644
--- a/drivers/staging/wlan-ng/p80211wext.c
+++ b/drivers/staging/wlan-ng/p80211wext.c
@@ -50,7 +50,6 @@
 #include <linux/uaccess.h>
 #include <asm/byteorder.h>
 #include <linux/if_ether.h>
-#include <linux/bitops.h>
 
 #include "p80211types.h"
 #include "p80211hdr.h"
-- 
1.7.0.3.296.g9776a

[PATCH 10/16] USB gadget r8a66597-udc.c: duplicated include

[Andrea Gelmini]

drivers/usb/gadget/r8a66597-udc.c: linux/err.h is included more than once.

Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net>
---
 drivers/usb/gadget/r8a66597-udc.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/drivers/usb/gadget/r8a66597-udc.c b/drivers/usb/gadget/r8a66597-udc.c
index 5e13d23..8b45145 100644
--- a/drivers/usb/gadget/r8a66597-udc.c
+++ b/drivers/usb/gadget/r8a66597-udc.c
@@ -23,7 +23,6 @@
 #include <linux/module.h>
 #include <linux/interrupt.h>
 #include <linux/delay.h>
-#include <linux/err.h>
 #include <linux/io.h>
 #include <linux/platform_device.h>
 #include <linux/clk.h>
-- 
1.7.0.3.296.g9776a

Re: [PATCH 10/16] USB gadget r8a66597-udc.c: duplicated include

[Paul Mundt]

On Thu, Mar 25, 2010 at 06:22:40PM +0100, Andrea Gelmini wrote:
> drivers/usb/gadget/r8a66597-udc.c: linux/err.h is included more than once.
> 
> Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net>

It seems the same fix was done in two different trees and merged at
different times, resulting in the duplication now.

Applied, thanks.

[PATCH 11/16] XFS xfs_trace.c: duplicated include

[Andrea Gelmini]

fs/xfs/linux-2.6/xfs_trace.c: xfs_attr_sf.h is included more than once.

Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net>
---
 fs/xfs/linux-2.6/xfs_trace.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/fs/xfs/linux-2.6/xfs_trace.c b/fs/xfs/linux-2.6/xfs_trace.c
index 5a10760..cb840e0 100644
--- a/fs/xfs/linux-2.6/xfs_trace.c
+++ b/fs/xfs/linux-2.6/xfs_trace.c
@@ -41,7 +41,6 @@
 #include "xfs_alloc.h"
 #include "xfs_bmap.h"
 #include "xfs_attr.h"
-#include "xfs_attr_sf.h"
 #include "xfs_attr_leaf.h"
 #include "xfs_log_priv.h"
 #include "xfs_buf_item.h"
-- 
1.7.0.3.296.g9776a

Re: [PATCH 11/16] XFS xfs_trace.c: duplicated include

[Alex Elder]

On Thu, 2010-03-25 at 18:22 +0100, Andrea Gelmini wrote:
> fs/xfs/linux-2.6/xfs_trace.c: xfs_attr_sf.h is included more than once.
> 
> Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net>

Looks good.	-Alex

Reviewed-by: Alex Elder <aelder@sgi.com>

> ---
>  fs/xfs/linux-2.6/xfs_trace.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/fs/xfs/linux-2.6/xfs_trace.c b/fs/xfs/linux-2.6/xfs_trace.c
> index 5a10760..cb840e0 100644
> --- a/fs/xfs/linux-2.6/xfs_trace.c
> +++ b/fs/xfs/linux-2.6/xfs_trace.c
> @@ -41,7 +41,6 @@
>  #include "xfs_alloc.h"
>  #include "xfs_bmap.h"
>  #include "xfs_attr.h"
> -#include "xfs_attr_sf.h"
>  #include "xfs_attr_leaf.h"
>  #include "xfs_log_priv.h"
>  #include "xfs_buf_item.h"

[PATCH 12/16] Scripts lex.c: remove extra spaces

[Andrea Gelmini]

scripts/genksyms/lex.c: deleted extra spaces

Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net>
---
 scripts/genksyms/lex.c_shipped |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/scripts/genksyms/lex.c_shipped b/scripts/genksyms/lex.c_shipped
index 2ac23bc..5682dfd 100644
--- a/scripts/genksyms/lex.c_shipped
+++ b/scripts/genksyms/lex.c_shipped
@@ -27,7 +27,7 @@
 /* %endif */
 
 /* %if-c-only */
-    
+
 /* %endif */
 
 /* %if-c-only */
-- 
1.7.0.3.296.g9776a

Re: [PATCH 12/16] Scripts lex.c: remove extra spaces

[Michal Marek]

On 25.3.2010 18:22, Andrea Gelmini wrote:
> scripts/genksyms/lex.c: deleted extra spaces
> 
> Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net>
> ---
>  scripts/genksyms/lex.c_shipped |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/scripts/genksyms/lex.c_shipped b/scripts/genksyms/lex.c_shipped
> index 2ac23bc..5682dfd 100644
> --- a/scripts/genksyms/lex.c_shipped
> +++ b/scripts/genksyms/lex.c_shipped
> @@ -27,7 +27,7 @@
>  /* %endif */
>  
>  /* %if-c-only */
> -    
> +
>  /* %endif */

This is a generated file, I don't think there is value in manually
fixing coding style issues in it, each subsequent update would overwrite
the changes.

Michal

Re: [PATCH 12/16] Scripts lex.c: remove extra spaces

[Andrea Gelmini]

2010/3/26 Michal Marek <mmarek@suse.cz>:
> This is a generated file, I don't think there is value in manually
> fixing coding style issues in it, each subsequent update would overwrite
> the changes.

You're right. I saw it after send.

Thanks a lot,
Andrea

[PATCH 13/16] Tools perf builtin-trace.c: duplicated includes

[Andrea Gelmini]

tools/perf/builtin-trace.c: util/exec_cmd.h and util/trace-event.h are included more than once.

Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net>
---
 tools/perf/builtin-trace.c |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)

diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c
index 407041d..3c699c5 100644
--- a/tools/perf/builtin-trace.c
+++ b/tools/perf/builtin-trace.c
@@ -59,9 +59,6 @@ static int cleanup_scripting(void)
 #include "perf.h"
 #include "util/debug.h"
 
-#include "util/trace-event.h"
-#include "util/exec_cmd.h"
-
 static char const		*input_name = "perf.data";
 
 static int process_sample_event(event_t *event, struct perf_session *session)
-- 
1.7.0.3.296.g9776a

Re: [PATCH 13/16] Tools perf builtin-trace.c: duplicated includes

[Ingo Molnar]

* Andrea Gelmini <andrea.gelmini@gelma.net> wrote:

> tools/perf/builtin-trace.c: util/exec_cmd.h and util/trace-event.h are included more than once.
> 
> Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net>
> ---
>  tools/perf/builtin-trace.c |    3 ---
>  1 files changed, 0 insertions(+), 3 deletions(-)
> 
> diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c
> index 407041d..3c699c5 100644
> --- a/tools/perf/builtin-trace.c
> +++ b/tools/perf/builtin-trace.c
> @@ -59,9 +59,6 @@ static int cleanup_scripting(void)
>  #include "perf.h"
>  #include "util/debug.h"
>  
> -#include "util/trace-event.h"
> -#include "util/exec_cmd.h"
> -
>  static char const		*input_name = "perf.data";
>  
>  static int process_sample_event(event_t *event, struct perf_session *session)

Please send a more complete patch that fixes the root cause of the 
duplication: a few header files are in the middle of the .c file - all 
inclusions should be at the top of the file.

Thanks,

	Ingo

Re: [PATCH 13/16] Tools perf builtin-trace.c: duplicated includes

[Andrea Gelmini]

2010/3/26 Ingo Molnar <mingo@elte.hu>:
> Please send a more complete patch that fixes the root cause of the
> duplication: a few header files are in the middle of the .c file - all
> inclusions should be at the top of the file.

I try to be less intrusive as possibile.
Now I reworked the patch, and I'll send it in a while.

Thanks a lot for your advices,
Andrea

Re: [PATCH 13/16] Tools perf builtin-trace.c: duplicated includes

[Ingo Molnar]

* Andrea Gelmini <andrea.gelmini@gelma.net> wrote:

> tools/perf/builtin-trace.c: util/exec_cmd.h and util/trace-event.h are included more than once.

Also, could you please update your patch to fix the subject lines of these 
auto-generated patches? The subject lines are missing a verb. The correct one 
would be:

 Subject: [PATCH 13/16] Tools perf builtin-trace.c: Remove duplicated #includes

Thanks,

	Ingo

[PATCH 1/2] Tools perf builtin-trace.c: #includes cleanup

[Andrea Gelmini]

Removed util/exec_cmd.h and util/trace-event.h included more than once.
Grouped and ordered includes.

Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net>
---
 tools/perf/builtin-trace.c |   19 +++++++------------
 1 files changed, 7 insertions(+), 12 deletions(-)

diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c
index 407041d..c743c86 100644
--- a/tools/perf/builtin-trace.c
+++ b/tools/perf/builtin-trace.c
@@ -1,13 +1,16 @@
 #include "builtin.h"
+#include "perf.h"
 
-#include "util/util.h"
 #include "util/cache.h"
+#include "util/debug.h"
+#include "util/exec_cmd.h"
+#include "util/header.h"
+#include "util/parse-options.h"
+#include "util/session.h"
 #include "util/symbol.h"
 #include "util/thread.h"
-#include "util/header.h"
-#include "util/exec_cmd.h"
 #include "util/trace-event.h"
-#include "util/session.h"
+#include "util/util.h"
 
 static char const		*script_name;
 static char const		*generate_script_lang;
@@ -54,14 +57,6 @@ static int cleanup_scripting(void)
 	return scripting_ops->stop_script();
 }
 
-#include "util/parse-options.h"
-
-#include "perf.h"
-#include "util/debug.h"
-
-#include "util/trace-event.h"
-#include "util/exec_cmd.h"
-
 static char const		*input_name = "perf.data";
 
 static int process_sample_event(event_t *event, struct perf_session *session)
-- 
1.7.0.3.296.g9776a

[PATCH 2/2] Tools perf builtin-trace.c: %Ld -> %lld

[Andrea Gelmini]

Chackpatch.pl cleanup:
WARNING: %Ld/%Lu are not-standard C, use %lld/%llu
+·⁖⁖dump_printf("(IP, %d): %d/%d: %#Lx period: %Ld\n", event->header.misc,

Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net>
---
 tools/perf/builtin-trace.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c
index c743c86..49b772f 100644
--- a/tools/perf/builtin-trace.c
+++ b/tools/perf/builtin-trace.c
@@ -71,7 +71,7 @@ static int process_sample_event(event_t *event, struct perf_session *session)
 
 	event__parse_sample(event, session->sample_type, &data);
 
-	dump_printf("(IP, %d): %d/%d: %#Lx period: %Ld\n", event->header.misc,
+	dump_printf("(IP, %d): %d/%d: %#Lx period: %lld\n", event->header.misc,
 		    data.pid, data.tid, data.ip, data.period);
 
 	thread = perf_session__findnew(session, event->ip.pid);
-- 
1.7.0.3.296.g9776a

[PATCH 14/16] Tools perf probe-finder.c: duplicated include

[Andrea Gelmini]

tools/perf/util/probe-finder.c: string.h is included more than once.

Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net>
---
 tools/perf/util/probe-finder.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/tools/perf/util/probe-finder.c b/tools/perf/util/probe-finder.c
index 1e6c65e..682eb37 100644
--- a/tools/perf/util/probe-finder.c
+++ b/tools/perf/util/probe-finder.c
@@ -32,7 +32,6 @@
 #include <stdarg.h>
 #include <ctype.h>
 
-#include "string.h"
 #include "event.h"
 #include "debug.h"
 #include "util.h"
-- 
1.7.0.3.296.g9776a

Re: [PATCH 14/16] Tools perf probe-finder.c: duplicated include

[Masami Hiramatsu]

Hi Andrea,

Andrea Gelmini wrote:
> tools/perf/util/probe-finder.c: string.h is included more than once.

Would you mean that <string.h> and "string.h" are duplicated? 
If so, NAK, sorry. Those are different, <string.h> is for
/usr/include/string.h, and "string.h" is for tools/perf/util/string.h.

Thank you,

> 
> Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net>
> ---
>  tools/perf/util/probe-finder.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/tools/perf/util/probe-finder.c b/tools/perf/util/probe-finder.c
> index 1e6c65e..682eb37 100644
> --- a/tools/perf/util/probe-finder.c
> +++ b/tools/perf/util/probe-finder.c
> @@ -32,7 +32,6 @@
>  #include <stdarg.h>
>  #include <ctype.h>
>  
> -#include "string.h"
>  #include "event.h"
>  #include "debug.h"
>  #include "util.h"

-- 
Masami Hiramatsu
e-mail: mhiramat@redhat.com

Re: [PATCH 14/16] Tools perf probe-finder.c: duplicated include

[Andrea Gelmini]

2010/3/25 Masami Hiramatsu <mhiramat@redhat.com>:
> Would you mean that <string.h> and "string.h" are duplicated?
> If so, NAK, sorry. Those are different, <string.h> is for
> /usr/include/string.h, and "string.h" is for tools/perf/util/string.h.

I'm an asshole...
Sorry, you're right.

Ciao,
Andrea

Re: [PATCH 14/16] Tools perf probe-finder.c: duplicated include

[KOSAKI Motohiro]

> Hi Andrea,
> 
> Andrea Gelmini wrote:
> > tools/perf/util/probe-finder.c: string.h is included more than once.
> 
> Would you mean that <string.h> and "string.h" are duplicated? 
> If so, NAK, sorry. Those are different, <string.h> is for
> /usr/include/string.h, and "string.h" is for tools/perf/util/string.h.
> 
> Thank you,

I think this discussion suggested "string.h" should be renameed more review
friendly name. probably.

Re: [PATCH 14/16] Tools perf probe-finder.c: duplicated include

[Masami Hiramatsu]

KOSAKI Motohiro wrote:
>> Hi Andrea,
>>
>> Andrea Gelmini wrote:
>>> tools/perf/util/probe-finder.c: string.h is included more than once.
>>
>> Would you mean that <string.h> and "string.h" are duplicated? 
>> If so, NAK, sorry. Those are different, <string.h> is for
>> /usr/include/string.h, and "string.h" is for tools/perf/util/string.h.
>>
>> Thank you,
> 
> I think this discussion suggested "string.h" should be renameed more review
> friendly name. probably.

Hmm, we'd better review files under tools/utils/include too. :(
(not sure why we have those files, because some files includes
 headers from original include directory, as like as 
 "../../include/linux/blahblah.h")

Thank you,

-- 
Masami Hiramatsu
e-mail: mhiramat@redhat.com

Re: [PATCH 14/16] Tools perf probe-finder.c: duplicated include

[Arnaldo Carvalho de Melo]

Em Fri, Mar 26, 2010 at 11:44:15AM -0400, Masami Hiramatsu escreveu:
> KOSAKI Motohiro wrote:
> >> Hi Andrea,
> >>
> >> Andrea Gelmini wrote:
> >>> tools/perf/util/probe-finder.c: string.h is included more than once.
> >>
> >> Would you mean that <string.h> and "string.h" are duplicated? 
> >> If so, NAK, sorry. Those are different, <string.h> is for
> >> /usr/include/string.h, and "string.h" is for tools/perf/util/string.h.
> >>
> >> Thank you,
> > 
> > I think this discussion suggested "string.h" should be renameed more review
> > friendly name. probably.

String should be renamed, yes, I'll do that.
 
> Hmm, we'd better review files under tools/utils/include too. :(
> (not sure why we have those files, because some files includes
>  headers from original include directory, as like as 
>  "../../include/linux/blahblah.h")

To share code with the kernel (rbtree.[ch], list.h).

- Arnaldo

[PATCH 15/16] BTRFS ioctl.c: duplicated include

[Andrea Gelmini]

fs/btrfs/ioctl.c: ctree.h is included more than once.

Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net>
---
 fs/btrfs/ioctl.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/fs/btrfs/ioctl.c b/fs/btrfs/ioctl.c
index 2845c6c..5c9f8b3 100644
--- a/fs/btrfs/ioctl.c
+++ b/fs/btrfs/ioctl.c
@@ -48,7 +48,6 @@
 #include "print-tree.h"
 #include "volumes.h"
 #include "locking.h"
-#include "ctree.h"
 
 /* Mask out flags that are inappropriate for the given type of inode. */
 static inline __u32 btrfs_mask_flags(umode_t mode, __u32 flags)
-- 
1.7.0.3.296.g9776a

[PATCH 16/16] Video omap lcd_omap3beagle.c: duplicated include

[Andrea Gelmini]

drivers/video/omap/lcd_omap3beagle.c: plat/mux.h is included more than once.

Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net>
---
 drivers/video/omap/lcd_omap3beagle.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/drivers/video/omap/lcd_omap3beagle.c b/drivers/video/omap/lcd_omap3beagle.c
index ca75cc2..ac715f9 100644
--- a/drivers/video/omap/lcd_omap3beagle.c
+++ b/drivers/video/omap/lcd_omap3beagle.c
@@ -26,7 +26,6 @@
 #include <linux/i2c/twl.h>
 
 #include <plat/mux.h>
-#include <plat/mux.h>
 #include <asm/mach-types.h>
 
 #include "omapfb.h"
-- 
1.7.0.3.296.g9776a