From: Johannes Weiner <hannes@cmpxchg.org>
To: Yinghai Lu <yinghai@kernel.org>
Cc: Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>,
Andrew Morton <akpm@linux-foundation.org>,
David Miller <davem@davemloft.net>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org
Subject: Re: [PATCH 01/24] x86: Make smp_locks end with page alignment
Date: Sat, 27 Mar 2010 00:33:15 +0100 [thread overview]
Message-ID: <20100326233315.GC29222@cmpxchg.org> (raw)
In-Reply-To: <1269642114-16588-2-git-send-email-yinghai@kernel.org>
On Fri, Mar 26, 2010 at 03:21:31PM -0700, Yinghai Lu wrote:
> Try to fix
> ------------[ cut here ]------------
> WARNING: at arch/x86/mm/init.c:342 free_init_pages+0x4c/0xfa()
> free_init_pages: range [0x40daf000, 0x40db5c24] is not aligned
> Modules linked in:
> Pid: 0, comm: swapper Not tainted 2.6.34-rc2-tip-03946-g4f16b23-dirty #50
> Call Trace:
> [<40232e9f>] warn_slowpath_common+0x65/0x7c
> [<4021c9f0>] ? free_init_pages+0x4c/0xfa
> [<40881434>] ? _etext+0x0/0x24
> [<40232eea>] warn_slowpath_fmt+0x24/0x27
> [<4021c9f0>] free_init_pages+0x4c/0xfa
> [<40881434>] ? _etext+0x0/0x24
> [<40d3f4bd>] alternative_instructions+0xf6/0x100
> [<40d3fe4f>] check_bugs+0xbd/0xbf
> [<40d398a7>] start_kernel+0x2d5/0x2e4
> [<40d390ce>] i386_start_kernel+0xce/0xd5
> ---[ end trace 4eaa2a86a8e2da22 ]---
>
> Comments in vmlinux.lds.S already said:
> | /*
> | * smp_locks might be freed after init
> | * start/end must be page aligned
> | */
>
> Signed-off-by: Yinghai Lu <yinghai@kernel.org>
FWIW, Acked-by: Johannes Weiner <hannes@cmpxchg.org>
> ---
> arch/x86/kernel/vmlinux.lds.S | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/x86/kernel/vmlinux.lds.S b/arch/x86/kernel/vmlinux.lds.S
> index 44879df..2cc2497 100644
> --- a/arch/x86/kernel/vmlinux.lds.S
> +++ b/arch/x86/kernel/vmlinux.lds.S
> @@ -291,8 +291,8 @@ SECTIONS
> .smp_locks : AT(ADDR(.smp_locks) - LOAD_OFFSET) {
> __smp_locks = .;
> *(.smp_locks)
> - __smp_locks_end = .;
> . = ALIGN(PAGE_SIZE);
> + __smp_locks_end = .;
> }
>
> #ifdef CONFIG_X86_64
next prev parent reply other threads:[~2010-03-26 23:33 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-26 22:21 [PATCH -v8 00/24] use lmb with x86 Yinghai Lu
2010-03-26 22:21 ` [PATCH 01/24] x86: Make smp_locks end with page alignment Yinghai Lu
2010-03-26 23:33 ` Johannes Weiner [this message]
2010-03-26 22:21 ` [PATCH 02/24] x86: Make sure free_init_pages() free pages in boundary Yinghai Lu
2010-03-26 23:06 ` Johannes Weiner
2010-03-26 23:45 ` Yinghai Lu
2010-03-27 0:07 ` Johannes Weiner
2010-03-27 0:17 ` Yinghai Lu
2010-03-27 1:19 ` [PATCH -v3] " Yinghai Lu
2010-03-28 0:03 ` Johannes Weiner
2010-03-28 0:50 ` Yinghai Lu
2010-03-28 1:01 ` Johannes Weiner
2010-03-28 1:58 ` Yinghai Lu
2010-03-28 23:35 ` [patch v5] x86: page-alin initrd area size Johannes Weiner
2010-03-29 0:41 ` Yinghai Lu
2010-03-26 22:21 ` [PATCH 03/24] x86: Do not free zero sized per cpu areas Yinghai Lu
2010-03-26 23:42 ` Johannes Weiner
2010-03-26 23:49 ` Yinghai Lu
2010-03-26 23:54 ` Johannes Weiner
2010-03-26 23:56 ` Yinghai Lu
2010-03-27 1:18 ` [PATCH -v8] " Yinghai Lu
2010-03-26 22:21 ` [PATCH 04/24] lmb: Move lmb.c to mm/ Yinghai Lu
2010-03-26 22:21 ` [PATCH 05/24] lmb: Seperate region array from lmb_region struct Yinghai Lu
2010-03-26 22:21 ` [PATCH 06/24] lmb: Add find_lmb_area() Yinghai Lu
2010-03-26 22:21 ` [PATCH 07/24] lmb: Add reserve_lmb/free_lmb Yinghai Lu
2010-03-26 22:21 ` [PATCH 08/24] lmb: Add find_lmb_area_size() Yinghai Lu
2010-03-26 22:21 ` [PATCH 09/24] bootmem, x86: Add weak version of reserve_bootmem_generic Yinghai Lu
2010-03-26 22:21 ` [PATCH 10/24] lmb: Add lmb_to_bootmem() Yinghai Lu
2010-03-26 22:21 ` [PATCH 11/24] lmb: Add get_free_all_memory_range() Yinghai Lu
2010-03-26 22:21 ` [PATCH 12/24] lmb: Add lmb_register_active_regions() and lmb_hole_size() Yinghai Lu
2010-03-26 22:21 ` [PATCH 13/24] lmb: Prepare to include linux/lmb.h in core file Yinghai Lu
2010-03-26 22:21 ` [PATCH 14/24] lmb: Add find_memory_core_early() Yinghai Lu
2010-03-26 22:21 ` [PATCH 15/24] lmb: Add find_lmb_area_node() Yinghai Lu
2010-03-26 22:21 ` [PATCH 16/24] lmb: Add lmb_free_memory_size() Yinghai Lu
2010-03-26 22:21 ` [PATCH 17/24] lmb: Add lmb_memory_size() Yinghai Lu
2010-03-26 22:21 ` [PATCH 18/24] lmb: Add reserve_lmb_overlap_ok() Yinghai Lu
2010-03-26 22:21 ` [PATCH 19/24] x86: Add sanitize_e820_map() Yinghai Lu
2010-03-26 22:21 ` [PATCH 20/24] x86: Use lmb to replace early_res Yinghai Lu
2010-03-26 22:21 ` [PATCH 21/24] x86: Replace e820_/_early string with lmb_ Yinghai Lu
2010-03-26 22:21 ` [PATCH 22/24] x86: Remove not used early_res code Yinghai Lu
2010-03-26 22:21 ` [PATCH 23/24] x86, lmb: Use lmb_memory_size()/lmb_free_memory_size() to get correct dma_reserve Yinghai Lu
2010-03-26 22:21 ` [PATCH 24/24] x86: Align e820 ram range to page Yinghai Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100326233315.GC29222@cmpxchg.org \
--to=hannes@cmpxchg.org \
--cc=akpm@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=davem@davemloft.net \
--cc=hpa@zytor.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox