From: Vivek Goyal <vgoyal@redhat.com>
To: Chad Talbott <ctalbott@google.com>
Cc: Gui Jianfeng <guijianfeng@cn.fujitsu.com>,
jens.axboe@oracle.com, mrubin@google.com,
Li Zefan <lizf@cn.fujitsu.com>,
linux-kernel@vger.kernel.org, dpshah@google.com,
Nauman Rafique <nauman@google.com>
Subject: Re: [PATCH 0/4] io-controller: Use names rather than major:minor
Date: Fri, 26 Mar 2010 20:30:37 -0400 [thread overview]
Message-ID: <20100327003037.GD9280@redhat.com> (raw)
In-Reply-To: <20100327002404.GB9280@redhat.com>
On Fri, Mar 26, 2010 at 08:24:04PM -0400, Vivek Goyal wrote:
> On Fri, Mar 26, 2010 at 08:20:56PM -0400, Vivek Goyal wrote:
>
> [..]
> > > Which controllers are these?
> > >
> >
> > linux-2.6/Documentation/cgroups/devices.txt
> >
> > > > - Displaying both device major/minor and diskname is an option but that
> > > > makes the file format syntax little complicated and new rule setting
> > > > or removoal confusing.
> > >
> > > A few messages back you mentioned that you preferred device names
> > > because they would be better for users of the system. If there was a
> > > simple implementation, would you still be behind a new name-based
> > > interface? We could go that direction and maintain ABI by deprecating
> > > current interface and making a new interface with names.
> > >
> > > If you can't tell, I'm a big fan of using the name! :) It's *much*
> > > more consistent with the interfaces in /sys.
> >
> > /sys provides facility to access device both through device number
> > (/sys/dev/block/<major:minor>) and disk name (/sys/block/<diskname>). So
> > I don't know why do you think it is more consistent with /sys if we
> > use diskname.
> >
> > In general user space seems to be accessing devices using device files.
> > For example, blockdev utility.
>
> One more example is "blktrace".
Another example is "hdparm"
Vivek
prev parent reply other threads:[~2010-03-27 1:03 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-25 18:04 [PATCH 0/4] io-controller: Use names rather than major:minor Chad Talbott
2010-03-25 18:04 ` [PATCH 1/4] blkio_group key change: void * -> request_queue * Chad Talbott
2010-03-25 23:25 ` Vivek Goyal
2010-03-26 0:17 ` Chad Talbott
2010-03-25 18:04 ` [PATCH 2/4] Adds an RCU-protected pointer to request_queue that makes it easy to Chad Talbott
2010-03-25 23:02 ` Vivek Goyal
2010-03-25 18:04 ` [PATCH 3/4] io-controller: Add a new interface "weight_device" for IO-Controller Chad Talbott
2010-03-25 18:04 ` [PATCH 4/4] Use disk-names to set blkio.weight_device policy Chad Talbott
2010-03-26 1:31 ` [PATCH 0/4] io-controller: Use names rather than major:minor Gui Jianfeng
2010-03-26 15:20 ` Vivek Goyal
2010-03-26 22:54 ` Chad Talbott
2010-03-26 23:21 ` Divyesh Shah
2010-03-27 0:28 ` Vivek Goyal
2010-03-27 0:20 ` Vivek Goyal
2010-03-27 0:24 ` Vivek Goyal
2010-03-27 0:30 ` Vivek Goyal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100327003037.GD9280@redhat.com \
--to=vgoyal@redhat.com \
--cc=ctalbott@google.com \
--cc=dpshah@google.com \
--cc=guijianfeng@cn.fujitsu.com \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=mrubin@google.com \
--cc=nauman@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox