From: Frederic Weisbecker <fweisbec@gmail.com>
To: Tom Zanussi <tzanussi@gmail.com>
Cc: linux-kernel@vger.kernel.org, mingo@elte.hu, rostedt@goodmis.org,
k-keiichi@bx.jp.nec.com
Subject: Re: [RFC PATCH 2/7] perf: add pipe-specific header read/write and event processing code
Date: Sat, 27 Mar 2010 04:14:57 +0100 [thread overview]
Message-ID: <20100327031455.GN7166@nowhere> (raw)
In-Reply-To: <1267599929-8310-3-git-send-email-tzanussi@gmail.com>
On Wed, Mar 03, 2010 at 01:05:24AM -0600, Tom Zanussi wrote:
>
> +int perf_header__write_pipe(struct perf_header *self, int fd)
> +{
> + struct perf_file_header_pipe f_header;
> + int err;
> +
> + f_header = (struct perf_file_header_pipe){
> + .magic = PERF_MAGIC,
> + .size = sizeof(f_header),
> + };
> +
> + err = do_write(fd, &f_header, sizeof(f_header));
> + if (err < 0) {
> + pr_debug("failed to write perf pipe header\n");
> + return err;
> + }
> +
> + self->frozen = 1;
> + return 0;
> +}
I actually wonder why you bother with a header in the pipe mode,
since it only contains MAGIC and its size.
next prev parent reply other threads:[~2010-03-27 3:14 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-03 7:05 [RFC PATCH 0/7] perf: 'live mode' Tom Zanussi
2010-03-03 7:05 ` [RFC PATCH 1/7] perf: introduce special handling for pipe input/output Tom Zanussi
2010-03-03 7:05 ` [RFC PATCH 2/7] perf: add pipe-specific header read/write and event processing code Tom Zanussi
2010-03-27 3:14 ` Frederic Weisbecker [this message]
2010-03-27 22:57 ` Arnaldo Carvalho de Melo
2010-03-27 23:05 ` Arnaldo Carvalho de Melo
2010-03-27 23:12 ` Frederic Weisbecker
2010-03-28 0:15 ` Arnaldo Carvalho de Melo
2010-03-03 7:05 ` [RFC PATCH 3/7] perf: convert perf header attrs into attr events Tom Zanussi
2010-03-03 7:05 ` [RFC PATCH 4/7] perf: convert perf event types into event type events Tom Zanussi
2010-03-03 7:05 ` [RFC PATCH 5/7] perf: convert perf tracing data into a tracing_data event Tom Zanussi
2010-03-03 7:05 ` [RFC PATCH 6/7] perf: convert perf header build_ids into build_id events Tom Zanussi
2010-03-03 7:05 ` [RFC PATCH 7/7] perf trace/scripting: rwtop and sctop scripts Tom Zanussi
2010-03-04 11:18 ` [RFC PATCH 0/7] perf: 'live mode' Ingo Molnar
2010-03-27 23:00 ` Arnaldo Carvalho de Melo
2010-03-28 5:04 ` Tom Zanussi
2010-03-27 0:57 ` Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100327031455.GN7166@nowhere \
--to=fweisbec@gmail.com \
--cc=k-keiichi@bx.jp.nec.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
--cc=tzanussi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox