From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753896Ab0C0Wzu (ORCPT <rfc822;w@1wt.eu>);
	Sat, 27 Mar 2010 18:55:50 -0400
Received: from caramon.arm.linux.org.uk ([78.32.30.218]:46431 "EHLO
	caramon.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752638Ab0C0Wzt (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sat, 27 Mar 2010 18:55:49 -0400
Date: Sat, 27 Mar 2010 22:55:22 +0000
From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Marcelo Roberto Jimenez <mroberto@cpti.cetuc.puc-rio.br>
Cc: mad_soft@inbox.ru, rpjday@crashcourse.ca, jaswinderrajput@gmail.com,
       kristoffer.ericson@gmail.com, linux-arm-kernel@lists.infradead.org,
       linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: mach-sa1100: Put nanoEngine support back in the
	kernel.
Message-ID: <20100327225522.GD13203@n2100.arm.linux.org.uk>
References: <1268338199-32222-1-git-send-email-mroberto@cpti.cetuc.puc-rio.br>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1268338199-32222-1-git-send-email-mroberto@cpti.cetuc.puc-rio.br>
User-Agent: Mutt/1.5.19 (2009-01-05)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Mar 11, 2010 at 05:09:59PM -0300, Marcelo Roberto Jimenez wrote:
> --- /dev/null
> +++ b/arch/arm/configs/nanoengine_defconfig
> @@ -0,0 +1,1396 @@

Please don't include defconfigs along with other code.

> +/*
> + * linux/arch/arm/mach-sa1100/nanoengine.c
> + *
> + * Bright Star Engineering's nanoEngine board init code.
> + *
> + * Copyright (C) 2009 Marcelo Roberto Jimenez <mroberto@cpti.cetuc.puc-rio.br>
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> + *
> + */
> +
> +#include <linux/init.h>
> +#include <linux/kernel.h>
> +#include <linux/mtd/mtd.h>
> +#include <linux/mtd/partitions.h>
> +#include <linux/root_dev.h>
> +#include <linux/tty.h>

Do you really need tty.h in here?

> +
> +#include <asm/mach-types.h>
> +#include <asm/setup.h>
> +
> +#include <asm/mach/arch.h>
> +#include <asm/mach/flash.h>
> +#include <asm/mach/map.h>
> +#include <asm/mach/serial_sa1100.h>
> +
> +#include <mach/hardware.h>
> +
> +#include "generic.h"
> +
> +/* Flash bank 0 */
> +static struct mtd_partition nanoengine_partitions[] = {
> +	{
> +	.name		= "nanoEngine boot firmware and parameter table",

Each '{' should indent the next line by a tab.