From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Lai Jiangshan <laijs@cn.fujitsu.com>
Cc: Ingo Molnar <mingo@elte.hu>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] rcu: remove lock acquirement when very eary boot
Date: Sat, 27 Mar 2010 21:17:24 -0700 [thread overview]
Message-ID: <20100328041724.GR2343@linux.vnet.ibm.com> (raw)
In-Reply-To: <4BAEC985.6020302@cn.fujitsu.com>
On Sun, Mar 28, 2010 at 11:14:13AM +0800, Lai Jiangshan wrote:
>
> cleanup: remove lock acquirement when very eary boot
This is indeed a safe change, however, I am keeping this lock acquisition
and release for documentation purposes. Call me paranoid, but...
Thanx, Paul
> Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>
> ---
> diff --git a/kernel/rcutree.c b/kernel/rcutree.c
> index 112edb5..e6014e1 100644
> --- a/kernel/rcutree.c
> +++ b/kernel/rcutree.c
> @@ -1646,13 +1646,10 @@ EXPORT_SYMBOL_GPL(rcu_barrier_sched);
> static void __init
> rcu_boot_init_percpu_data(int cpu, struct rcu_state *rsp)
> {
> - unsigned long flags;
> int i;
> struct rcu_data *rdp = rsp->rda[cpu];
> - struct rcu_node *rnp = rcu_get_root(rsp);
>
> /* Set up local state, ensuring consistent view of global state. */
> - raw_spin_lock_irqsave(&rnp->lock, flags);
> rdp->grpmask = 1UL << (cpu - rdp->mynode->grplo);
> rdp->nxtlist = NULL;
> for (i = 0; i < RCU_NEXT_SIZE; i++)
> @@ -1662,7 +1659,6 @@ rcu_boot_init_percpu_data(int cpu, struct rcu_state *rsp)
> rdp->dynticks = &per_cpu(rcu_dynticks, cpu);
> #endif /* #ifdef CONFIG_NO_HZ */
> rdp->cpu = cpu;
> - raw_spin_unlock_irqrestore(&rnp->lock, flags);
> }
>
> /*
>
prev parent reply other threads:[~2010-03-28 4:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-28 3:14 [PATCH] rcu: remove lock acquirement when very eary boot Lai Jiangshan
2010-03-28 4:17 ` Paul E. McKenney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100328041724.GR2343@linux.vnet.ibm.com \
--to=paulmck@linux.vnet.ibm.com \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox