public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@ucw.cz>
To: Lars Lindley <lindley@coyote.org>
Cc: gregkh@suse.de, greg@kroah.com, penberg@cs.helsinki.fi,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: winbond: wb35tx_f.h Coding style fixes.
Date: Sun, 28 Mar 2010 14:01:44 +0200	[thread overview]
Message-ID: <20100328120144.GC1406@ucw.cz> (raw)
In-Reply-To: <1269759475-4920-1-git-send-email-lindley@coyote.org>

On Sun 2010-03-28 08:57:55, Lars Lindley wrote:
> I fixed the checkpatch.pl problems and converted the function
> arguments away from CamelCase and hungarian notation.
> 
> Signed-off-by: Lars Lindley <lindley@coyote.org>

ack.

> ---
>  drivers/staging/winbond/wb35tx_f.h |   18 ++++++++++--------
>  1 files changed, 10 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/staging/winbond/wb35tx_f.h b/drivers/staging/winbond/wb35tx_f.h
> index a7af9cb..1d3b515 100644
> --- a/drivers/staging/winbond/wb35tx_f.h
> +++ b/drivers/staging/winbond/wb35tx_f.h
> @@ -4,18 +4,20 @@
>  #include "core.h"
>  #include "wbhal_f.h"
>  
> -//====================================
> -// Interface function declare
> -//====================================
> -unsigned char Wb35Tx_initial(	 struct hw_data * pHwData );
> -void Wb35Tx_destroy(  struct hw_data * pHwData );
> -unsigned char Wb35Tx_get_tx_buffer(  struct hw_data * pHwData,  u8 **pBuffer );
> +/*
> + * ====================================
> + * Interface function declare
> + * ====================================
> + */
> +unsigned char Wb35Tx_initial(struct hw_data *hw_data);
> +void Wb35Tx_destroy(struct hw_data *hw_data);
> +unsigned char Wb35Tx_get_tx_buffer(struct hw_data *hw_data, u8 **buffer);
>  
>  void Wb35Tx_EP2VM_start(struct wbsoft_priv *adapter);
>  
>  void Wb35Tx_start(struct wbsoft_priv *adapter);
> -void Wb35Tx_stop(  struct hw_data * pHwData );
> +void Wb35Tx_stop(struct hw_data *hw_data);
>  
> -void Wb35Tx_CurrentTime(struct wbsoft_priv *adapter,  u32 TimeCount);
> +void Wb35Tx_CurrentTime(struct wbsoft_priv *adapter, u32 time_count);
>  
>  #endif

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

      reply	other threads:[~2010-03-28 12:01 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-28  6:57 [PATCH] staging: winbond: wb35tx_f.h Coding style fixes Lars Lindley
2010-03-28 12:01 ` Pavel Machek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100328120144.GC1406@ucw.cz \
    --to=pavel@ucw.cz \
    --cc=devel@driverdev.osuosl.org \
    --cc=greg@kroah.com \
    --cc=gregkh@suse.de \
    --cc=lindley@coyote.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=penberg@cs.helsinki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox