From: David Miller <davem@davemloft.net>
To: fweisbec@gmail.com
Cc: linux-kernel@vger.kernel.org, sparclinux@vger.kernel.org
Subject: Re: [BUG] fault while using perf callchains in sparc64
Date: Mon, 29 Mar 2010 13:09:31 -0700 (PDT) [thread overview]
Message-ID: <20100329.130931.149161813.davem@davemloft.net> (raw)
In-Reply-To: <20100328043446.GA11748@nowhere>
From: Frederic Weisbecker <fweisbec@gmail.com>
Date: Sun, 28 Mar 2010 06:34:49 +0200
> I get kernel crashes each time I use perf with callchains
> on sparc 64.
>
> It triggers with a simple:
>
> perf record -a -f -g sleep 1
This should fix it, thanks again.
sparc64: Properly truncate pt_regs framepointer in perf callback.
For 32-bit processes, we save the full 64-bits of the regs in pt_regs.
But unlike when the userspace actually does load and store
instructions, the top 32-bits don't get automatically truncated by the
cpu in kernel mode (because the kernel doesn't execute with PSTATE_AM
address masking enabled).
So we have to do it by hand.
Reported-by: Frederic Weisbecker <fweisbec@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
---
arch/sparc/kernel/perf_event.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/sparc/kernel/perf_event.c b/arch/sparc/kernel/perf_event.c
index 9f2b2ba..610112e 100644
--- a/arch/sparc/kernel/perf_event.c
+++ b/arch/sparc/kernel/perf_event.c
@@ -1337,7 +1337,7 @@ static void perf_callchain_user_32(struct pt_regs *regs,
callchain_store(entry, PERF_CONTEXT_USER);
callchain_store(entry, regs->tpc);
- ufp = regs->u_regs[UREG_I6];
+ ufp = regs->u_regs[UREG_I6] & 0xffffffffUL;
do {
struct sparc_stackf32 *usf, sf;
unsigned long pc;
--
1.7.0.3
next prev parent reply other threads:[~2010-03-29 20:09 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-28 4:34 [BUG] fault while using perf callchains in sparc64 Frederic Weisbecker
2010-03-29 2:02 ` David Miller
2010-03-29 3:23 ` Frederic Weisbecker
2010-03-29 19:56 ` David Miller
2010-03-29 20:09 ` David Miller [this message]
2010-03-29 20:49 ` Frederic Weisbecker
2010-03-29 21:01 ` David Miller
2010-03-29 21:11 ` Frederic Weisbecker
2010-03-29 21:19 ` David Miller
2010-03-29 21:28 ` Frederic Weisbecker
2010-03-29 22:02 ` David Miller
2010-03-29 22:21 ` Frederic Weisbecker
2010-03-29 22:32 ` David Miller
2010-04-01 9:06 ` Frederic Weisbecker
2010-04-01 8:09 ` David Miller
2010-04-01 9:38 ` Frederic Weisbecker
2010-04-01 9:02 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100329.130931.149161813.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).