From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Lai Jiangshan <laijs@cn.fujitsu.com>
Cc: Ingo Molnar <mingo@elte.hu>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] rcu: remove needless struct notifier_block predeclaration
Date: Sun, 28 Mar 2010 21:44:05 -0700 [thread overview]
Message-ID: <20100329044405.GC2343@linux.vnet.ibm.com> (raw)
In-Reply-To: <4BB01182.2090301@cn.fujitsu.com>
On Mon, Mar 29, 2010 at 10:33:38AM +0800, Lai Jiangshan wrote:
>
> cleanup: remove needless struct notifier_block predeclaration
Good catch!
These forward declarations used to be essential. ;-)
If they have been made available on purpose, I am all for applying
this patch. But if their appearance is accidental, perhaps to
disappear again in the next release, I would keep the forward
declarations.
Could you please check?
Thanx, Paul
> diff --git a/include/linux/rcutiny.h b/include/linux/rcutiny.h
> index a519587..ae7b05e 100644
> --- a/include/linux/rcutiny.h
> +++ b/include/linux/rcutiny.h
> @@ -86,8 +86,6 @@ static inline void synchronize_rcu_bh_expedited(void)
> synchronize_sched();
> }
>
> -struct notifier_block;
> -
> #ifdef CONFIG_NO_HZ
>
> extern void rcu_enter_nohz(void);
> diff --git a/include/linux/rcutree.h b/include/linux/rcutree.h
> index 42cc3a0..3be62e1 100644
> --- a/include/linux/rcutree.h
> +++ b/include/linux/rcutree.h
> @@ -30,8 +30,6 @@
> #ifndef __LINUX_RCUTREE_H
> #define __LINUX_RCUTREE_H
>
> -struct notifier_block;
> -
> extern void rcu_sched_qs(int cpu);
> extern void rcu_bh_qs(int cpu);
> extern int rcu_needs_cpu(int cpu);
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
prev parent reply other threads:[~2010-03-29 4:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-29 2:33 [PATCH] rcu: remove needless struct notifier_block predeclaration Lai Jiangshan
2010-03-29 4:44 ` Paul E. McKenney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100329044405.GC2343@linux.vnet.ibm.com \
--to=paulmck@linux.vnet.ibm.com \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox