From: Dan Carpenter <error27@gmail.com>
To: Lars Lindley <lindley@coyote.org>
Cc: gregkh@suse.de, greg@kroah.com, penberg@cs.helsinki.fi,
pavel@ucw.cz, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: winbond: wbhal_f.h Coding style fixes.
Date: Mon, 29 Mar 2010 12:43:22 +0300 [thread overview]
Message-ID: <20100329094322.GB15060@bicker> (raw)
In-Reply-To: <1269796259-8671-1-git-send-email-lindley@coyote.org>
On Sun, Mar 28, 2010 at 07:10:59PM +0200, Lars Lindley wrote:
> I fixed all checkpatch problems and also converted the
> function arguments from hungarian notation and CamelCase.
>
[snip]
> -#define hal_ibss_disconnect(_A) hal_stop_sync_bss(_A)
> +#define hal_ibss_disconnect(_A) (hal_stop_sync_bss(_A))
The parenthesis around hal_stop_sync_bss() aren't needed. They don't
hurt anything, but they're odd.
Also it appears that no one uses hal_ibss_disconnect().
So far as I'm concerned this can go in as is...
Acked-by: Dan Carpenter <error27@gmail.com>
regards,
dan carpenter
prev parent reply other threads:[~2010-03-29 9:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-28 17:10 [PATCH] staging: winbond: wbhal_f.h Coding style fixes Lars Lindley
2010-03-29 4:32 ` Pavel Machek
2010-03-29 9:43 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100329094322.GB15060@bicker \
--to=error27@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=greg@kroah.com \
--cc=gregkh@suse.de \
--cc=lindley@coyote.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=penberg@cs.helsinki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox