Re: [PATCHv3 0/2] tracing: function graph output for preempt/irqs-off tracers

Jiri Olsa
2010-03-31T07:37:53Z

On Mon, Mar 29, 2010 at 11:41:39AM -0400, Steven Rostedt wrote:
> On Mon, 2010-03-29 at 17:21 +0200, Jiri Olsa wrote:
>
> > > Understand what I'm trying to ask?
> >
> > ok, so what you mean is:
> > - dont clear the max_tr and
> > - add function graph events.
> >
> > So when the tracing_enabled and display-graph are disabled we will
> > get events output rather than 'unknown event' output... right?
>
> Right, although when the display-graph is disabled, we lose the /* */
> but that's fine.

ok, I have it done, but found another issue..

It's the tracer_flags which governs the tracer output. As I'm using
the function_graph tracer output functions, they follow function_graph
tracer's flags settings..

My first idea was a change that would allow tracer using flags
of other tracers.. so, when enabling irqsoff tracer the function_graph
tracer's options would become available.

I made the patch but got to the set_flag function which can be overloaded
by tracer. So I'd need to remember the flags's tracer, and it does
not seem right.. :)

any ideas?

thanks,
jirka