From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Todd Fischer <todd.fischer@ridgerun.com>
Cc: linux-kernel@vger.kernel.org,
davinci-linux-open-source@linux.davincidsp.com,
sameo@linux.intel.com, lrg@slimlogic.co.uk
Subject: Re: [PATCH 2/5] Make room for other tps6507x drivers to have board specific initialization data.
Date: Mon, 29 Mar 2010 13:54:40 +0100 [thread overview]
Message-ID: <20100329125440.GC8434@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <1269634292-29686-3-git-send-email-todd.fischer@ridgerun.com>
On Fri, Mar 26, 2010 at 02:11:29PM -0600, Todd Fischer wrote:
> Need mfd structure that can hold pointers to sub-driver initialization
> and run time data.
Please provide a more verbose changelog. What needs this structure?
> /**
> + * tps_board points to pmic related constants
> + * coming from the board-evm file.
> + */
> +
> + tps_board = (struct tps6507x_board *)client->dev.platform_data;
There's no need to cast away from void and you ought to be using
dev_get_platdata().
> + if (!tps_board)
> + return -EIO;
> +
This seems like the wrong error code to be using here.
next prev parent reply other threads:[~2010-03-29 12:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-26 20:11 [PATCH 0/5] TPS6507x MFD driver Todd Fischer
2010-03-26 20:11 ` [PATCH 1/5] Move TPS6507x register definition to header file Todd Fischer
2010-03-26 20:11 ` [PATCH 2/5] Make room for other tps6507x drivers to have board specific initialization data Todd Fischer
2010-03-26 20:11 ` [PATCH 3/5] Add MFD driver for TPS6507x family of multi-function chips Todd Fischer
2010-03-26 20:11 ` [PATCH 4/5] Cleaned up name space so each MFD sub-driver uses a different name space Todd Fischer
2010-03-26 20:11 ` [PATCH 5/5] Move TPS6507x regulator driver from being stand-alone to using the MFD TPS6507x driver Todd Fischer
2010-03-29 13:00 ` [PATCH 3/5] Add MFD driver for TPS6507x family of multi-function chips Mark Brown
2010-03-29 12:54 ` Mark Brown [this message]
2010-03-29 12:50 ` [PATCH 1/5] Move TPS6507x register definition to header file Mark Brown
2010-04-02 13:35 ` [PATCH 0/5] TPS6507x MFD driver Samuel Ortiz
2010-04-02 21:33 ` [PATCH 0/4]-V2 " Todd Fischer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100329125440.GC8434@rakim.wolfsonmicro.main \
--to=broonie@opensource.wolfsonmicro.com \
--cc=davinci-linux-open-source@linux.davincidsp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
--cc=sameo@linux.intel.com \
--cc=todd.fischer@ridgerun.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox