From: Oliver Neukum <oliver@neukum.org>
To: Jiri Kosina <jkosina@suse.cz>
Cc: Greg KH <greg@kroah.com>, USB list <linux-usb@vger.kernel.org>,
Mauro Carvalho Chehab <mchehab@infradead.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/5] usb:Push BKL on open down into the drivers
Date: Mon, 29 Mar 2010 15:30:36 +0200 [thread overview]
Message-ID: <201003291530.37183.oliver@neukum.org> (raw)
In-Reply-To: <alpine.LNX.2.00.1003291159470.24576@pobox.suse.cz>
Am Montag 29 März 2010 12:04:51 schrieb Jiri Kosina:
> For hiddev, this causes a problem, as you introduced BKL into
> hiddev_connect() exactly because of the proper dependency -- we have the
> BKL there to avoid race after usb_register_dev() -- once the device node
> has been created, open() could happen on it.
Hi,
it seems to me you cannot deadlock with the BKL and an rwsem,
as BKL will be dropped if a task blocks on the rwsem. This is not
a nice feature of the BKL to use. Do you have an alternative idea?
Regards
Oliver
next prev parent reply other threads:[~2010-03-29 13:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <201001131533.15704.oliver@neukum.org>
2010-03-29 10:04 ` [PATCH 4/5] usb:Push BKL on open down into the drivers Jiri Kosina
2010-03-29 13:30 ` Oliver Neukum [this message]
2010-03-29 13:46 ` Jiri Kosina
2010-03-30 6:46 ` Oliver Neukum
2010-03-30 8:13 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201003291530.37183.oliver@neukum.org \
--to=oliver@neukum.org \
--cc=greg@kroah.com \
--cc=jkosina@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mchehab@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox