From: Jean Delvare <khali@linux-fr.org>
To: Wolfram Sang <w.sang@pengutronix.de>
Cc: kernel-janitors@vger.kernel.org, linux-i2c@vger.kernel.org,
linux-kernel@vger.kernel.org,
Wolfram Sang <w.sang@pengutronix.de>,
Corentin Labbe <corentin.labbe@geomatys.fr>,
"Mark M. Hoffman" <mhoffman@lightlink.com>,
Juerg Haefliger <juergh@gmail.com>,
Riku Voipio <riku.voipio@iki.fi>,
"Hans J. Koch" <hjk@linutronix.de>,
Marc Hulsman <m.hulsman@tudelft.nl>,
Rudolf Marek <r.marek@assembler.cz>,
lm-sensors@lm-sensors.org
Subject: Re: [PATCH 05/24] hwmon: fix dangling pointers
Date: Mon, 29 Mar 2010 16:30:07 +0200 [thread overview]
Message-ID: <20100329163007.0ec2f04d@hyperion.delvare> (raw)
In-Reply-To: <1269094385-16114-6-git-send-email-w.sang@pengutronix.de>
On Sat, 20 Mar 2010 15:12:46 +0100, Wolfram Sang wrote:
> Fix I2C-drivers which missed setting clientdata to NULL before freeing the
> structure it points to. Also fix drivers which do this _after_ the structure
> was freed already.
>
> Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
> Cc: Jean Delvare <khali@linux-fr.org>
> Cc: Corentin Labbe <corentin.labbe@geomatys.fr>
> Cc: "Mark M. Hoffman" <mhoffman@lightlink.com>
> Cc: Juerg Haefliger <juergh@gmail.com>
> Cc: Riku Voipio <riku.voipio@iki.fi>
> Cc: "Hans J. Koch" <hjk@linutronix.de>
> Cc: Marc Hulsman <m.hulsman@tudelft.nl>
> Cc: Rudolf Marek <r.marek@assembler.cz>
> ---
>
> Found using coccinelle, then reviewed. Full patchset is available via
> kernel-janitors, linux-i2c, and LKML.
> ---
> drivers/hwmon/ad7414.c | 2 ++
> drivers/hwmon/ad7418.c | 2 ++
> drivers/hwmon/adm1021.c | 2 ++
> drivers/hwmon/adm1025.c | 2 ++
> drivers/hwmon/adm1026.c | 2 ++
> drivers/hwmon/adm1029.c | 2 ++
> drivers/hwmon/adm1031.c | 2 ++
> drivers/hwmon/adm9240.c | 2 ++
> drivers/hwmon/ads7828.c | 5 ++++-
> drivers/hwmon/adt7462.c | 2 ++
> drivers/hwmon/adt7470.c | 2 ++
> drivers/hwmon/adt7475.c | 2 ++
> drivers/hwmon/amc6821.c | 2 ++
> drivers/hwmon/asb100.c | 2 ++
> drivers/hwmon/atxp1.c | 2 ++
> drivers/hwmon/dme1737.c | 2 ++
> drivers/hwmon/ds1621.c | 2 ++
> drivers/hwmon/f75375s.c | 4 ++--
> drivers/hwmon/g760a.c | 4 ++--
> drivers/hwmon/gl518sm.c | 2 ++
> drivers/hwmon/gl520sm.c | 2 ++
> drivers/hwmon/lm63.c | 2 ++
> drivers/hwmon/lm77.c | 2 ++
> drivers/hwmon/lm78.c | 2 ++
> drivers/hwmon/lm80.c | 2 ++
> drivers/hwmon/lm83.c | 2 ++
> drivers/hwmon/lm85.c | 2 ++
> drivers/hwmon/lm87.c | 2 ++
> drivers/hwmon/lm90.c | 2 ++
> drivers/hwmon/lm92.c | 2 ++
> drivers/hwmon/lm93.c | 2 ++
> drivers/hwmon/lm95241.c | 1 +
> drivers/hwmon/ltc4215.c | 2 ++
> drivers/hwmon/ltc4245.c | 2 ++
> drivers/hwmon/max1619.c | 2 ++
> drivers/hwmon/max6650.c | 2 ++
> drivers/hwmon/pcf8591.c | 6 +++++-
> drivers/hwmon/smsc47m192.c | 2 ++
> drivers/hwmon/thmc50.c | 2 ++
> drivers/hwmon/tmp401.c | 1 +
> drivers/hwmon/w83791d.c | 2 ++
> drivers/hwmon/w83792d.c | 2 ++
> drivers/hwmon/w83793.c | 1 +
> drivers/hwmon/w83l785ts.c | 2 ++
> drivers/hwmon/w83l786ng.c | 2 ++
> 45 files changed, 92 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/hwmon/ad7414.c b/drivers/hwmon/ad7414.c
> index bfda8c8..0cfae01 100644
> --- a/drivers/hwmon/ad7414.c
> +++ b/drivers/hwmon/ad7414.c
> @@ -220,6 +220,7 @@ static int ad7414_probe(struct i2c_client *client,
> exit_remove:
> sysfs_remove_group(&client->dev.kobj, &ad7414_group);
> exit_free:
> + i2c_set_clientdata(client, NULL);
> kfree(data);
> exit:
> return err;
> @@ -231,6 +232,7 @@ static int __devexit ad7414_remove(struct i2c_client *client)
>
> hwmon_device_unregister(data->hwmon_dev);
> sysfs_remove_group(&client->dev.kobj, &ad7414_group);
> + i2c_set_clientdata(client, NULL);
> kfree(data);
> return 0;
> }
> (...)
As discussed on the i2c list, I won't apply this patch. Instead, we
want i2c-core to call i2c_set_clientdata() after the remove() function
returns. This saves a lot of code duplication.
--
Jean Delvare
next prev parent reply other threads:[~2010-03-29 14:30 UTC|newest]
Thread overview: 67+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-20 14:12 i2c-drivers: Remove dangling pointers Wolfram Sang
2010-03-20 14:12 ` [PATCH 01/24] mtd/maps/pismo: remove dangling pointer and a leak Wolfram Sang
2010-03-20 14:57 ` Russell King
2010-03-20 15:31 ` Wolfram Sang
2010-03-20 15:41 ` Russell King
2010-03-21 8:30 ` David Woodhouse
2010-03-30 12:26 ` Wolfram Sang
2010-03-20 14:12 ` [PATCH 02/24] power/ds2782: really clear i2c_clientdata on exit Wolfram Sang
2010-03-20 21:53 ` Ryan Mallon
2010-03-22 17:08 ` Anton Vorontsov
2010-03-30 12:28 ` Wolfram Sang
2010-03-20 14:12 ` [PATCH 03/24] usb/otg/isp1301_omap: Fix dangling pointer Wolfram Sang
2010-03-20 20:09 ` Felipe Balbi
2010-03-30 12:30 ` Wolfram Sang
2010-03-20 14:12 ` [PATCH 04/24] gpio: fix dangling pointers Wolfram Sang
2010-03-30 12:31 ` Wolfram Sang
2010-03-20 14:12 ` [PATCH 05/24] hwmon: " Wolfram Sang
2010-03-29 14:30 ` Jean Delvare [this message]
2010-03-20 14:12 ` [PATCH 06/24] input/keyboard: " Wolfram Sang
2010-03-20 19:20 ` Dmitry Torokhov
2010-03-21 1:59 ` Wolfram Sang
2010-03-30 12:35 ` Wolfram Sang
2010-03-20 14:12 ` [PATCH 07/24] input/touchscreen: " Wolfram Sang
2010-03-20 14:12 ` [PATCH 08/24] leds: " Wolfram Sang
2010-03-30 12:36 ` Wolfram Sang
2010-03-20 14:12 ` [PATCH 09/24] macintosh: " Wolfram Sang
2010-03-20 14:12 ` [PATCH 10/24] media/radio: " Wolfram Sang
2010-03-20 14:12 ` [PATCH 11/24] media/radio/si470x: " Wolfram Sang
2010-03-20 14:12 ` [PATCH 12/24] media/video: " Wolfram Sang
2010-03-20 22:02 ` Hans Verkuil
2010-03-21 11:31 ` Wolfram Sang
2010-03-21 13:46 ` Jean Delvare
2010-03-21 14:14 ` Mark Brown
2010-03-21 16:09 ` Hans Verkuil
2010-03-22 20:33 ` Jean Delvare
2010-03-22 21:51 ` Mark Brown
2010-03-23 0:35 ` Wolfram Sang
2010-03-30 12:39 ` Wolfram Sang
2010-04-01 8:32 ` Hans Verkuil
2010-03-22 20:36 ` Jean Delvare
2010-03-20 14:12 ` [PATCH 13/24] mfd: " Wolfram Sang
2010-03-20 17:22 ` Mark Brown
2010-03-20 20:25 ` Jean Delvare
2010-03-21 2:09 ` Wolfram Sang
2010-03-25 10:41 ` Samuel Ortiz
2010-03-30 12:41 ` Wolfram Sang
2010-03-20 14:12 ` [PATCH 14/24] misc: " Wolfram Sang
2010-03-30 12:44 ` Wolfram Sang
2010-03-20 14:12 ` [PATCH 15/24] misc/eeprom: " Wolfram Sang
2010-03-20 14:12 ` [PATCH 16/24] power: " Wolfram Sang
2010-03-20 14:12 ` [PATCH 17/24] regulator: " Wolfram Sang
2010-03-20 17:23 ` Mark Brown
2010-03-22 19:49 ` Liam Girdwood
2010-03-30 12:47 ` Wolfram Sang
2010-03-20 14:12 ` [PATCH 18/24] rtc: " Wolfram Sang
2010-03-30 12:49 ` Wolfram Sang
2010-03-20 14:13 ` [PATCH 19/24] staging/dream: " Wolfram Sang
2010-03-20 14:13 ` [PATCH 20/24] staging/go7007: " Wolfram Sang
2010-03-20 14:13 ` [PATCH 21/24] staging/iio/adc: " Wolfram Sang
2010-03-22 12:41 ` Jonathan Cameron
2010-03-20 14:13 ` [PATCH 22/24] staging/iio/light: " Wolfram Sang
2010-03-22 12:41 ` Jonathan Cameron
2010-03-20 14:13 ` [PATCH 23/24] video/matrox: " Wolfram Sang
2010-04-05 14:04 ` James Simmons
2010-03-20 14:13 ` [PATCH 24/24] w1/masters: " Wolfram Sang
2010-04-05 22:59 ` i2c-drivers: Remove " Ben Dooks
2010-04-06 0:06 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100329163007.0ec2f04d@hyperion.delvare \
--to=khali@linux-fr.org \
--cc=corentin.labbe@geomatys.fr \
--cc=hjk@linutronix.de \
--cc=juergh@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
--cc=m.hulsman@tudelft.nl \
--cc=mhoffman@lightlink.com \
--cc=r.marek@assembler.cz \
--cc=riku.voipio@iki.fi \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox