From: Al Viro <viro@ZenIV.linux.org.uk>
To: Daniel J Blueman <daniel.blueman@gmail.com>
Cc: Trond Myklebust <trond.myklebust@fys.uio.no>,
linux-nfs@vger.kernel.org,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [2.6.34-rc2 NFS4 oops] open error path failure...
Date: Mon, 29 Mar 2010 20:03:07 +0100 [thread overview]
Message-ID: <20100329190307.GJ30031@ZenIV.linux.org.uk> (raw)
In-Reply-To: <6278d2221003291136p6481fe8emfb039403343c082@mail.gmail.com>
On Mon, Mar 29, 2010 at 07:36:45PM +0100, Daniel J Blueman wrote:
> Hi Trond,
>
> When open fails and should return EPERM [1], instead we see an oops
> [2]. I see this on 2.6.34-rc1 and -rc2 mainline; NFS4 server is
> mainline 2.6.33.1.
>
> Let me know if you can't reproduce it and I'll provide some analysis
> from this end.
Joy... ERR_PTR(-EPERM) in nd.intent.file, and whoever had called
lookup_instantiate_filp() hadn't bothered to check the return value.
OK, I think I see what's going on. Replace
lookup_instantiate_filp(nd, (struct dentry *)state, NULL);
return 1;
with
lookup_instantiate_filp(nd, (struct dentry *)state, NULL);
return state;
in fs/nfs/nfs4proc.c:nfs4_open_revalidate() and see if everything works
properly (or just lose the lookup_instantiate_filp() in there and simply
return state).
next prev parent reply other threads:[~2010-03-29 19:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-29 18:36 [2.6.34-rc2 NFS4 oops] open error path failure Daniel J Blueman
2010-03-29 19:03 ` Al Viro [this message]
2010-03-29 19:21 ` Daniel J Blueman
2010-03-29 21:22 ` Trond Myklebust
2010-03-31 11:20 ` Daniel J Blueman
2010-03-31 14:21 ` Chuck Lever
2010-04-02 10:34 ` Daniel J Blueman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100329190307.GJ30031@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=daniel.blueman@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=trond.myklebust@fys.uio.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox