Re: [PATCH v6 7/8, needs improvement] hid: add suspend/resume hooks for hid drivers

Oliver Neukum
2010-04-11T20:27:34Z

Am Sonntag, 11. April 2010 20:40:02 schrieb Bruno Prémont:
> On Sun, 11 April 2010 Jiri Kosina <jkosina@suse.cz> wrote:
> > > As far as I understand the code, in auto-suspend case if the driver
> > > sends commands to the device it will have to call usbhid_wait_io().
> > > Please correct me if I'm wrong!
> >
> > It's not needed. There is a queuing mechanism in place on
> > 'resumption_waker' workqueue.
>
> So the driver is not allowed to ask the device to do something
> at auto-suspend time (as that would abort the auto-suspension).

>From within suspend()?

Generally if the driver wants to talk to a device that's a good
reason to wake up a device.

Regards
Oliver