[PATCH v3 0/6] hid: new driver for PicoLCD device

Bruno Prémont
2010-03-24T23:01:20Z

This series adds support for PicoLCD USB HID device adding support for
the various features in different patches so each patch concentrates
on a device class.

Changes since revision 2:
- drop most inline keywords
- use mutex to protect question-wait-for-answer requests
- use mutex to protect flash erase+write+write sequence
- add support for simulated 8-bit mode (advertised grayscale and
translated by "pixel & 0x80 ? 1 : 0"
Explaining Jaya's curiosity about my choice, there seem to be
(near) no userspace application willing to operate on a 1bpp
framebuffer. Simulated 8bpp tested with links (dfbsee has
unrelated? issues, fbv seems to always want color map for 8bpp
even for grayscale...)
Is it correct to call "8bpp grayscale" TRUECOLOR? If not, what's
the right FB_VISUAL_* name?
- fix a couple checkpatch warnings/errors
(there are multiple "longer than 80 char" lines left though
I don't think it's worth/readable to kill them all)
- extract version check into a separate function
- do direct keycode lookup
- replace sysfs_{create,remove}_file with device_{create,remove}_file
- correct initial update of framebuffer

I've not changed the Kconfig part from v2 as an attempt to add
sub-options which would select FB, LCD_CLASS, BACKLIGHT_CLASS
or LEDS_CLASS ended up in kbuild to complain about a dependency loop
for FB.
I'm wondering why I didn't get such a loop for first revision when
HID_PICOLCD did select everything...
As this is build-cosmetic it can be looked into at a later time.

The series depends on my previous patch adding HID suspend support
(I've not yet looked at improving it). Except that one the series is
on top of 2.6.34-rc2.
Note that debugfs registration is wrong on hotplug (a fix for this
one is waiting in Jiri's upstream branch:
http://git.kernel.org/?p=linux/kernel/git/jikos/hid.git;a=commitdiff;h=4da361b69102cdffe73006771eae7504d2cb8736 )

Bruno