Re: [PATCH v6 7/8, needs improvement] hid: add suspend/resume hooks for hid drivers

Jiri Kosina
2010-03-31T12:16:01Z

On Tue, 30 Mar 2010, Bruno Prémont wrote:

> Add suspend/resume hooks for HID drivers so these can do some
> additional state adjustment when device gets suspended/resumed.
>
> This patch calls these hooks from usbhid suspend/resume functions,
> only calling suspend on plain suspend, not autosuspend.
> (it might be worth adding an autosuspend parameter to suspend
> hook and calling suspend in both cases)
>
> Signed-off-by: Bruno Prémont <bonbons@linux-vserver.org>
> ---
>
> Note:
> this patch needs improvements as mentionned by Olivier Neukum:
> - suspend hook for both system suspend and autosuspend
> - no call of hook on USB-HID-resume failure

I agree with Oliver's comments.

We should also consider putting the hook calls into bluetooth
implementation as well (though there is currently no driver using it, but
I don't know, maybe Wacom could benefit from it as well).

Thanks,

--
Jiri Kosina
SUSE Labs, Novell Inc.