Re: [PATCH v3 1/6] hid: new driver for PicoLCD device

Bruno Prémont
2010-03-26T09:30:42Z

On Thu, 25 March 2010 Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote:
> On Wed, Mar 24, 2010 at 11:40:22PM +0100, Bruno Prémont wrote:
> > + for (i = 0; i < PICOLCD_KEYS; i++) {
> > + int key = ((int *)idev->keycode)[i];
>
> Keycodes are now short, not int. Also, just do:
>
> input_set_capability(idev, EV_KEY, data->keycode[i]);
>
> > + if (key < KEY_MAX && key >= 0)
> > + input_set_capability(idev, EV_KEY, key);

Oops, I was not careful enough when switching over...
Thanks for catching,
Bruno