Re: [PATCH v3 1/6] hid: new driver for PicoLCD device

Jiri Kosina
2010-03-26T20:59:24Z

On Fri, 26 Mar 2010, Bruno Prémont wrote:

> > > + for (i = 0; i < PICOLCD_KEYS; i++) {
> > > + int key = ((int *)idev->keycode)[i];
> >
> > Keycodes are now short, not int. Also, just do:
> >
> > input_set_capability(idev, EV_KEY, data->keycode[i]);
> >
> > > + if (key < KEY_MAX && key >= 0)
> > > + input_set_capability(idev, EV_KEY, key);
>
> Oops, I was not careful enough when switching over...

Dmitry, thanks a lot for rapid review the driver.

Bruno, could you please fix this and submit a followup 1/6 patch, so that
I could queue the driver in my tree?

I have almost finished going over the driver and haven't encountered any
other issues that would require immediate fixing.

Still, it would be nice to have the framebuffer/LCD/backlight bits
reviewed by respective subsystem maintainers. But I'll probably queue the
driver nevertheless and add potential ACKs later.

Thanks,

--
Jiri Kosina
SUSE Labs, Novell Inc.