From: Oleg Nesterov <oleg@redhat.com>
To: Ingo Molnar <mingo@elte.hu>, Peter Zijlstra <peterz@infradead.org>
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] set_cpus_allowed_ptr: don't use rq->migration_thread after unlock
Date: Tue, 30 Mar 2010 18:58:29 +0200 [thread overview]
Message-ID: <20100330165829.GA18284@redhat.com> (raw)
Trivial typo fix. rq->migration_thread can be NULL after task_rq_unlock(),
this is why we have "mt" which should be used instead.
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
---
sched.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- 34-rc1/kernel/sched.c~S_C_A_P_USE_MT 2010-03-29 19:46:21.000000000 +0200
+++ 34-rc1/kernel/sched.c 2010-03-30 18:52:05.000000000 +0200
@@ -5365,7 +5365,7 @@ int set_cpus_allowed_ptr(struct task_str
get_task_struct(mt);
task_rq_unlock(rq, &flags);
- wake_up_process(rq->migration_thread);
+ wake_up_process(mt);
put_task_struct(mt);
wait_for_completion(&req.done);
tlb_migrate_finish(p->mm);
next reply other threads:[~2010-03-30 17:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-30 16:58 Oleg Nesterov [this message]
2010-03-30 17:15 ` [PATCH] set_cpus_allowed_ptr: don't use rq->migration_thread after unlock Peter Zijlstra
2010-04-02 19:10 ` [tip:sched/urgent] sched: set_cpus_allowed_ptr(): Don't " tip-bot for Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100330165829.GA18284@redhat.com \
--to=oleg@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox