From: Greg KH <gregkh@suse.de>
To: Pavan Savoy <pavan_savoy@ti.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
marcel@holtmann.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers:staging: sources for ST core
Date: Tue, 30 Mar 2010 14:47:12 -0700 [thread overview]
Message-ID: <20100330214712.GB1388@suse.de> (raw)
In-Reply-To: <54146.53246.qm@web94908.mail.in2.yahoo.com>
On Wed, Mar 31, 2010 at 02:35:55AM +0530, Pavan Savoy wrote:
> So, something like the below is ok, I have defined my own pr_fmt,
> however default log level on my board is 7, and hence pr_info is a bit
> more annoying than usual.
No, a driver should use dev_dbg() and other dev_printk() calls, not
pr_debug() or anything like that.
Please don't roll your own formats, use the ones that are well defined
and uniquely describe your driver and device in a format that the whole
kernel uses.
thanks,
greg k-h
next prev parent reply other threads:[~2010-03-30 22:39 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-25 23:20 [v4] New ldisc for WiLink7.0 pavan_savoy
2010-03-25 23:20 ` [PATCH] serial: TTY: new ldiscs for staging pavan_savoy
2010-03-25 23:20 ` [PATCH] drivers:staging: sources for ST core pavan_savoy
2010-03-25 23:20 ` [PATCH] drivers:staging: sources for Init manager module pavan_savoy
2010-03-25 23:20 ` [PATCH] drivers:staging: sources for HCI LL PM protocol pavan_savoy
2010-03-25 23:20 ` [PATCH] drivers:staging: sources for ST header file pavan_savoy
2010-03-25 23:20 ` [PATCH] drivers:staging: Kconfig, Makefile for TI's ST ldisc pavan_savoy
2010-03-25 23:20 ` [PATCH] Documentation:staging: add TODO and ABI to ti-st pavan_savoy
2010-03-25 23:20 ` [PATCH] bluetooth: BT driver using ST for TI combo devices pavan_savoy
2010-03-30 11:24 ` [PATCH] drivers:staging: sources for HCI LL PM protocol Alan Cox
2010-03-30 15:03 ` Pavan Savoy
2010-03-30 18:33 ` Alan Cox
2010-03-30 11:22 ` [PATCH] drivers:staging: sources for ST core Alan Cox
2010-03-30 15:53 ` Pavan Savoy
2010-03-30 20:38 ` Greg KH
2010-03-30 21:05 ` Pavan Savoy
2010-03-30 21:47 ` Greg KH [this message]
2010-03-31 2:24 ` Joe Perches
2010-03-25 23:30 ` [PATCH] serial: TTY: new ldiscs for staging Alan Cox
2010-03-26 15:08 ` Pavan Savoy
2010-03-28 4:58 ` [v4] New ldisc for WiLink7.0 Greg KH
-- strict thread matches above, loose matches on Subject: below --
2010-03-30 22:50 [PATCH] drivers:staging: sources for ST core Pavan Savoy
2010-03-31 17:30 ` Greg KH
2010-03-31 18:02 ` Pavan Savoy
2010-03-31 18:19 ` Greg KH
2010-03-31 19:27 Pavan Savoy
2010-03-31 20:24 ` Greg KH
2010-03-31 23:57 ` Pavan Savoy
2010-04-01 9:20 ` Alan Cox
2010-04-01 17:20 Pavan Savoy
2010-04-01 22:43 ` Pavan Savoy
2010-04-01 23:27 ` Alan Cox
2010-04-05 16:18 ` Pavan Savoy
2010-04-08 18:16 New ldisc for WiLink7.0 pavan_savoy
2010-04-08 18:16 ` [PATCH] serial: TTY: new ldiscs for staging pavan_savoy
2010-04-08 18:16 ` [PATCH] drivers:staging: sources for ST core pavan_savoy
2010-04-13 15:06 ` Pavan Savoy
2010-04-13 15:12 ` Alan Cox
2010-04-19 18:37 ` Pavan Savoy
2010-04-26 21:24 ` Pavan Savoy
2010-04-26 22:03 ` Alan Cox
2010-04-26 22:06 ` Pavan Savoy
2010-04-27 16:15 Pavan Savoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100330214712.GB1388@suse.de \
--to=gregkh@suse.de \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=pavan_savoy@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox