From: Oleg Nesterov <oleg@redhat.com>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Badari Pulavarty <pbadari@us.ibm.com>,
Christoph Hellwig <hch@lst.de>, Janak Desai <janak@us.ibm.com>,
Roland McGrath <roland@redhat.com>,
Stanislaw Gruszka <sgruszka@redhat.com>,
Sukadev Bhattiprolu <sukadev@us.ibm.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH -mm] sys_unshare: simplify the not-really-implemented CLONE_THREAD/SIGHAND/VM code
Date: Thu, 1 Apr 2010 01:53:53 +0200 [thread overview]
Message-ID: <20100331235353.GA7565@redhat.com> (raw)
In-Reply-To: <20100323230526.GA9932@redhat.com>
On 03/24, Oleg Nesterov wrote:
>
> That said, I do not really care about this cleanup. I did it just because
> I sent another patch which touches check_unshare_flags(), and I was really
> surprised that ~70 lines in kernel/fork.c do nothing but confuse the reader.
I changed my mind. I do care ;)
Seriously, Eric, it is just stupid this code does nothing but complicates
fork.c, and unless you prove this patch is wrong you can't convince me
this patch is bad idea.
> Please nack this patch and lets forget it ;)
Yes. You have all rights to nack it and I won't insist even if I disagree.
But please do this explicitly, otherwise I'll resend it.
Oleg.
next prev parent reply other threads:[~2010-03-31 23:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-23 17:08 [PATCH -mm] sys_unshare: simplify the not-really-implemented CLONE_THREAD/SIGHAND/VM code Oleg Nesterov
2010-03-23 21:02 ` Eric W. Biederman
2010-03-23 23:05 ` Oleg Nesterov
2010-03-31 23:53 ` Oleg Nesterov [this message]
2010-04-09 20:03 ` Roland McGrath
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100331235353.GA7565@redhat.com \
--to=oleg@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=hch@lst.de \
--cc=janak@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pbadari@us.ibm.com \
--cc=roland@redhat.com \
--cc=sgruszka@redhat.com \
--cc=sukadev@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).