From: Frans Pop <elendil@planet.nl>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
adobriyan@gmail.com, helight.xu@gmail.com,
viro@zeniv.linux.org.uk
Subject: Re: [PATCH] proc: Report file name on detected read_proc overflow
Date: Thu, 1 Apr 2010 16:41:56 +0200 [thread overview]
Message-ID: <201004011641.58462.elendil@planet.nl> (raw)
In-Reply-To: <4BB49B0E.8070306@siemens.com>
Jan Kiszka wrote:
> - "proc_file_read: Apparent buffer overflow!\n");
> + "proc_file_read: Apparent buffer "
> + "overflow reading \"%s\"!\n",
> + file->f_path.dentry->d_name.name);
I think it would be good to keep "overflow" on the first line as that
may be what people will grep the source for. And maybe use single quotes
around the file name. So:
+ "proc_file_read: Apparent buffer overflow "
+ "reading '%s'!\n",
+ file->f_path.dentry->d_name.name);
Cheers,
FJP
next prev parent reply other threads:[~2010-04-01 14:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-01 13:09 [PATCH] proc: Report file name on detected read_proc overflow Jan Kiszka
2010-04-01 14:41 ` Frans Pop [this message]
2010-04-01 16:16 ` [PATCH v2] " Jan Kiszka
2010-04-02 6:28 ` [PATCH] " Alexey Dobriyan
2010-04-06 16:48 ` Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201004011641.58462.elendil@planet.nl \
--to=elendil@planet.nl \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=helight.xu@gmail.com \
--cc=jan.kiszka@siemens.com \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox