* [PATCH] backing-dev: Handle class_create() failure
@ 2010-04-02 7:27 Anton Blanchard
2010-04-02 7:46 ` Jens Axboe
0 siblings, 1 reply; 2+ messages in thread
From: Anton Blanchard @ 2010-04-02 7:27 UTC (permalink / raw)
To: Andrew Morton, Jens Axboe; +Cc: linux-kernel
I hit this when we had a bug in IDR for a few days. Basically sysfs would
fail to create new inodes since it uses an IDR and therefore class_create would
fail.
While we are unlikely to see this fail we may as well handle it instead of
oopsing.
Signed-off-by: Anton Blanchard <anton@samba.org>
---
diff --git a/mm/backing-dev.c b/mm/backing-dev.c
index 0e8ca03..f13e067 100644
--- a/mm/backing-dev.c
+++ b/mm/backing-dev.c
@@ -227,6 +227,9 @@ static struct device_attribute bdi_dev_attrs[] = {
static __init int bdi_class_init(void)
{
bdi_class = class_create(THIS_MODULE, "bdi");
+ if (IS_ERR(bdi_class))
+ return PTR_ERR(bdi_class);
+
bdi_class->dev_attrs = bdi_dev_attrs;
bdi_debug_init();
return 0;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] backing-dev: Handle class_create() failure
2010-04-02 7:27 [PATCH] backing-dev: Handle class_create() failure Anton Blanchard
@ 2010-04-02 7:46 ` Jens Axboe
0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2010-04-02 7:46 UTC (permalink / raw)
To: Anton Blanchard; +Cc: Andrew Morton, linux-kernel
On Fri, Apr 02 2010, Anton Blanchard wrote:
>
> I hit this when we had a bug in IDR for a few days. Basically sysfs would
> fail to create new inodes since it uses an IDR and therefore class_create would
> fail.
>
> While we are unlikely to see this fail we may as well handle it instead of
> oopsing.
Thanks Anton, applied.
--
Jens Axboe
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-04-02 7:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-04-02 7:27 [PATCH] backing-dev: Handle class_create() failure Anton Blanchard
2010-04-02 7:46 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox