* [patch] mfd: off by one issue
@ 2010-03-28 11:28 Dan Carpenter
2010-04-02 9:55 ` Samuel Ortiz
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2010-03-28 11:28 UTC (permalink / raw)
To: Samuel Ortiz
Cc: Paul Fertser, Lars-Peter Clausen, Mark Brown, Arnaud Patard,
linux-kernel, kernel-janitors
"pcf->irq_handler" has PCF50633_NUM_IRQ elements.
Signed-off-by: Dan Carpenter <error27@gmail.com>
diff --git a/drivers/mfd/pcf50633-core.c b/drivers/mfd/pcf50633-core.c
index 03dcc92..4f13608 100644
--- a/drivers/mfd/pcf50633-core.c
+++ b/drivers/mfd/pcf50633-core.c
@@ -217,7 +217,7 @@ static struct attribute_group pcf_attr_group = {
int pcf50633_register_irq(struct pcf50633 *pcf, int irq,
void (*handler) (int, void *), void *data)
{
- if (irq < 0 || irq > PCF50633_NUM_IRQ || !handler)
+ if (irq < 0 || irq >= PCF50633_NUM_IRQ || !handler)
return -EINVAL;
if (WARN_ON(pcf->irq_handler[irq].handler))
@@ -234,7 +234,7 @@ EXPORT_SYMBOL_GPL(pcf50633_register_irq);
int pcf50633_free_irq(struct pcf50633 *pcf, int irq)
{
- if (irq < 0 || irq > PCF50633_NUM_IRQ)
+ if (irq < 0 || irq >= PCF50633_NUM_IRQ)
return -EINVAL;
mutex_lock(&pcf->lock);
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [patch] mfd: off by one issue
2010-03-28 11:28 [patch] mfd: off by one issue Dan Carpenter
@ 2010-04-02 9:55 ` Samuel Ortiz
0 siblings, 0 replies; 2+ messages in thread
From: Samuel Ortiz @ 2010-04-02 9:55 UTC (permalink / raw)
To: Dan Carpenter, Paul Fertser, Lars-Peter Clausen, Mark Brown,
Arnaud Patard, linux-kernel, kernel-janitors
Hi Dan,
On Sun, Mar 28, 2010 at 02:28:08PM +0300, Dan Carpenter wrote:
> "pcf->irq_handler" has PCF50633_NUM_IRQ elements.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
Patch applied, many thanks.
Cheers,
Samuel.
> diff --git a/drivers/mfd/pcf50633-core.c b/drivers/mfd/pcf50633-core.c
> index 03dcc92..4f13608 100644
> --- a/drivers/mfd/pcf50633-core.c
> +++ b/drivers/mfd/pcf50633-core.c
> @@ -217,7 +217,7 @@ static struct attribute_group pcf_attr_group = {
> int pcf50633_register_irq(struct pcf50633 *pcf, int irq,
> void (*handler) (int, void *), void *data)
> {
> - if (irq < 0 || irq > PCF50633_NUM_IRQ || !handler)
> + if (irq < 0 || irq >= PCF50633_NUM_IRQ || !handler)
> return -EINVAL;
>
> if (WARN_ON(pcf->irq_handler[irq].handler))
> @@ -234,7 +234,7 @@ EXPORT_SYMBOL_GPL(pcf50633_register_irq);
>
> int pcf50633_free_irq(struct pcf50633 *pcf, int irq)
> {
> - if (irq < 0 || irq > PCF50633_NUM_IRQ)
> + if (irq < 0 || irq >= PCF50633_NUM_IRQ)
> return -EINVAL;
>
> mutex_lock(&pcf->lock);
--
Intel Open Source Technology Centre
http://oss.intel.com/
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-04-02 9:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-03-28 11:28 [patch] mfd: off by one issue Dan Carpenter
2010-04-02 9:55 ` Samuel Ortiz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox