From: Samuel Ortiz <sameo@linux.intel.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Liam Girdwood <lrg@slimlogic.co.uk>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mfd: Add WM8994 interrupt controller support
Date: Fri, 2 Apr 2010 13:30:28 +0200 [thread overview]
Message-ID: <20100402113027.GF8010@sortiz.org> (raw)
In-Reply-To: <20100402102422.GA32467@rakim.wolfsonmicro.main>
On Fri, Apr 02, 2010 at 11:24:22AM +0100, Mark Brown wrote:
> On Fri, Apr 02, 2010 at 12:17:55PM +0200, Samuel Ortiz wrote:
> > Hi Mark,
> >
> > On Tue, Mar 30, 2010 at 03:12:02PM +0100, Mark Brown wrote:
> > > On Mon, Mar 29, 2010 at 09:28:45PM +0100, Mark Brown wrote:
> > >
> > > > + printk(KERN_CRIT "%x %x\n", status[0], status[1]);
> > >
> > > Clearly this is debug code and shouldn't be there in an actual version.
> > > I'll remove this when resubmitting after review & merge path are sorted
> > > out.
>
> > All right, I won't merge it for now.
>
> Did you see the question in the original posting about where this should
> be merged?
Sorry, I missed that part.
> The bulk of the code using these interrupts will be the
> CODEC driver for the device, but the CODEC driver needs to be able to
> check if interrupts are set up at all (since commonly CODECs don't have
> an IRQ line wired up) so it'd be nice if it were possible to merge via
> ASoC.
I'm fine with that, please carry this patch. During the next merge window I'll
wait for your code to be merged upstream, fix any potential merge conflicts
and send my pull request.
Also, I had a look at the code and feel free to add my:
Acked-by: Samuel Ortiz <sameo@linux.intel.com>
to it.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
next prev parent reply other threads:[~2010-04-02 11:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-29 20:28 [PATCH] mfd: Add WM8994 interrupt controller support Mark Brown
2010-03-30 14:12 ` Mark Brown
2010-04-02 10:17 ` Samuel Ortiz
2010-04-02 10:24 ` Mark Brown
2010-04-02 11:30 ` Samuel Ortiz [this message]
2010-04-02 11:44 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100402113027.GF8010@sortiz.org \
--to=sameo@linux.intel.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox