From: Matt Mackall <mpm@selenic.com>
To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
San Mehat <san@google.com>,
linux-kernel@vger.kernel.org,
Brian Swetland <swetland@google.com>,
Dave Hansen <haveblue@us.ibm.com>,
Andrew Morton <akpm@linux-foundation.org>,
n-horiguchi@ah.jp.nec.com
Subject: Re: [PATCH] proc: pagemap: Hold mmap_sem during page walk
Date: Fri, 2 Apr 2010 09:30:58 -0500 [thread overview]
Message-ID: <20100402143058.GA22639@waste.org> (raw)
In-Reply-To: <20100402091129.bca35057.kamezawa.hiroyu@jp.fujitsu.com>
On Fri, Apr 02, 2010 at 09:11:29AM +0900, KAMEZAWA Hiroyuki wrote:
> int ret = -ESRCH;
...
> + pm.len = PM_ENTRY_BYTES * (PAGEMAP_WALK_SIZE >> PAGE_SHIFT);
> + pm.buffer = kmalloc(pm.len, GFP_TEMPORARY);
> + if (!pm.buffer)
> goto out_mm;
...
> out_mm:
> mmput(mm);
Looks like this gets the wrong return code?
--
Mathematics is the supreme nostalgia of our time.
next prev parent reply other threads:[~2010-04-02 14:31 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-31 17:23 [PATCH] proc: pagemap: Hold mmap_sem during page walk San Mehat
2010-03-31 17:54 ` Linus Torvalds
2010-03-31 21:40 ` Matt Mackall
2010-04-01 1:33 ` Linus Torvalds
2010-04-01 2:10 ` KOSAKI Motohiro
2010-04-01 3:20 ` Matt Mackall
2010-04-01 4:27 ` Linus Torvalds
2010-04-01 5:54 ` KOSAKI Motohiro
2010-04-01 5:55 ` KAMEZAWA Hiroyuki
2010-04-01 6:05 ` KOSAKI Motohiro
2010-04-01 6:09 ` KAMEZAWA Hiroyuki
2010-04-01 6:34 ` KAMEZAWA Hiroyuki
2010-04-01 7:09 ` Matt Mackall
2010-04-01 7:21 ` KOSAKI Motohiro
2010-04-01 15:10 ` Linus Torvalds
2010-04-02 0:11 ` KAMEZAWA Hiroyuki
2010-04-02 14:30 ` Matt Mackall [this message]
2010-04-06 6:48 ` KAMEZAWA Hiroyuki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100402143058.GA22639@waste.org \
--to=mpm@selenic.com \
--cc=akpm@linux-foundation.org \
--cc=haveblue@us.ibm.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=san@google.com \
--cc=swetland@google.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox