From: Samuel Ortiz <sameo@linux.intel.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mfd: Improve WM831x AUXADC completion handling
Date: Fri, 2 Apr 2010 18:27:05 +0200 [thread overview]
Message-ID: <20100402162704.GM8010@sortiz.org> (raw)
In-Reply-To: <1270222263-14203-1-git-send-email-broonie@opensource.wolfsonmicro.com>
On Fri, Apr 02, 2010 at 04:31:03PM +0100, Mark Brown wrote:
> Currently completion of WM831x AUXADC conversions is monitored by
> checking for convertor enable. Due to the mechanism used to ensure
> data corruption is avoided when reading AUXADC data there may under
> heavy I/O be a window where this bit has cleared but the conversion
> results have not been updated. Data availability is only guaranteed
> after the AUXADC data interrupt has been asserted.
>
> Avoid this by always using the interrupt to detect completion. If the
> chip IRQ is not set up then we poll the IRQ status register for up to
> 5ms. If it is set up then we rely on the data done interrupt with a
> vastly increased timeout, failing the conversion if the interrupt is
> not generated.
>
> This also saves a register read when using interrupts.
>
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Applied to my for-next branch, thanks.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
prev parent reply other threads:[~2010-04-02 16:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-02 15:31 [PATCH] mfd: Improve WM831x AUXADC completion handling Mark Brown
2010-04-02 16:27 ` Samuel Ortiz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100402162704.GM8010@sortiz.org \
--to=sameo@linux.intel.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox