From: Arnaldo Carvalho de Melo <acme@redhat.com>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Hitoshi Mitake <mitake@dcl.info.waseda.ac.jp>,
mingo@elte.hu, linux-kernel@vger.kernel.org, h.mitake@gmail.com,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH] Swap including order of util.h and string.h of util/string.c
Date: Sun, 4 Apr 2010 20:23:23 -0300 [thread overview]
Message-ID: <20100404232323.GD27773@ghostprotocols.net> (raw)
In-Reply-To: <20100404143441.GA5608@nowhere>
Em Sun, Apr 04, 2010 at 04:34:43PM +0200, Frederic Weisbecker escreveu:
> On Sun, Apr 04, 2010 at 05:13:18PM +0900, Hitoshi Mitake wrote:
> > Current util/string.c includes headers in this order: string.h, util.h
> > But this causes build error because __USE_GNU definition
> > is needed for strndup() definition like this,
> > % make -j
> > touch .perf.dev.null
> > CC util/string.o
> > cc1: warnings being treated as errors
> > util/string.c: In function ‘argv_split’:
> > util/string.c:171: error: implicit declaration of function ‘strndup’
> > util/string.c:171: error: incompatible implicit declaration of built-in function ‘strndup’
>
> Thanks, I've queued it as I have the same problem and I'm
> about to send a perf/core queue.
Sorry about that and thanks for queueing it up, keeping this tempo of
getting patches queued up and pushed up upstream for perf is really nice
inasmuch as we keep it sane, and so far I think it is really being
excellent! :-)
- Arnaldo
prev parent reply other threads:[~2010-04-04 23:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-04 8:13 [PATCH] Swap including order of util.h and string.h of util/string.c Hitoshi Mitake
2010-04-04 14:34 ` Frederic Weisbecker
2010-04-04 23:23 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100404232323.GD27773@ghostprotocols.net \
--to=acme@redhat.com \
--cc=a.p.zijlstra@chello.nl \
--cc=fweisbec@gmail.com \
--cc=h.mitake@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mitake@dcl.info.waseda.ac.jp \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox