From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755141Ab0DFDOg (ORCPT ); Mon, 5 Apr 2010 23:14:36 -0400 Received: from ozlabs.org ([203.10.76.45]:58126 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751115Ab0DFDOb (ORCPT ); Mon, 5 Apr 2010 23:14:31 -0400 From: Rusty Russell To: David Miller Subject: Re: [PATCH] virtio-net: move sg off stack Date: Tue, 6 Apr 2010 12:44:28 +0930 User-Agent: KMail/1.12.2 (Linux/2.6.31-19-generic; KDE/4.3.2; i686; ; ) Cc: mst@redhat.com, jpirko@redhat.com, xma@us.ibm.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20100331.031636.04083770.davem@davemloft.net> <20100331124156.GA4598@redhat.com> <20100401.192648.185498218.davem@davemloft.net> In-Reply-To: <20100401.192648.185498218.davem@davemloft.net> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201004061244.29187.rusty@rustcorp.com.au> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2 Apr 2010 12:56:48 pm David Miller wrote: > From: "Michael S. Tsirkin" > Date: Wed, 31 Mar 2010 15:41:58 +0300 > > > Move sg structure off stack and into virtnet_info structure. > > This helps remove extra sg_init_table calls as well as reduce > > stack usage. > > > > Signed-off-by: Michael S. Tsirkin > > --- > > > > Compile-tested only for now. > > Shirley, Rusty Russell, does this fix CONFIG_DEBUG_SG=y for you? Yes, this fixes the BUG_ON() for me (trivial changes to base on Linus' tree only). Thanks, Rusty.