public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Jan III Sobieski <jan3sobi3ski@gmail.com>,
	Matthew Garrett <mjg@redhat.com>, Dmitry Torokhov <dtor@mail.ru>
Cc: Yong Wang <yong.y.wang@linux.intel.com>,
	LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH] eepc-wmi.c: Fix build error
Date: Wed, 7 Apr 2010 16:22:45 +0200	[thread overview]
Message-ID: <20100407142245.GA8714@elte.hu> (raw)
In-Reply-To: <k2h9c2470ce1004070257z7c45897o10fb7f4d7d1de8f@mail.gmail.com>


* Jan III Sobieski <jan3sobi3ski@gmail.com> wrote:

> Hi,
> 
>   GEN     .version
>   CHK     include/generated/compile.h
>   UPD     include/generated/compile.h
>   CC      init/version.o
>   LD      init/built-in.o
>   LD      .tmp_vmlinux1
> drivers/built-in.o: In function `eeepc_wmi_notify':
> /home/test/linux-2.6/drivers/platform/x86/eeepc-wmi.c:86: undefined
> reference to `sparse_keymap_report_event'

-tip testing has triggered this bug too, see the fix below.

	Ingo

--------------------------->
>From 763400ebb305711ebbd468c030db76d631400fe1 Mon Sep 17 00:00:00 2001
From: Ingo Molnar <mingo@elte.hu>
Date: Wed, 7 Apr 2010 16:15:51 +0200
Subject: [PATCH] eepc-wmi.c: Fix build error

-tip testing found:

eeepc-wmi.c:(.text+0x36673c): undefined reference to `sparse_keymap_report_event'
drivers/built-in.o: In function `eeepc_wmi_init':
eeepc-wmi.c:(.init.text+0x19cd0): undefined reference to `sparse_keymap_setup'
eeepc-wmi.c:(.init.text+0x19cf0): undefined reference to `sparse_keymap_free'
eeepc-wmi.c:(.init.text+0x19d0b): undefined reference to `sparse_keymap_free'
drivers/built-in.o: In function `eeepc_wmi_exit':
eeepc-wmi.c:(.exit.text+0x2e87): undefined reference to `sparse_keymap_free'

To fix this select INPUT_SPARSEKMAP, like the ASUS driver does.

Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
 drivers/platform/x86/Kconfig |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
index 3046776..301e379 100644
--- a/drivers/platform/x86/Kconfig
+++ b/drivers/platform/x86/Kconfig
@@ -392,6 +392,7 @@ config EEEPC_WMI
 	depends on ACPI_WMI
 	depends on INPUT
 	depends on EXPERIMENTAL
+	select INPUT_SPARSEKMAP
 	---help---
 	  Say Y here if you want to support WMI-based hotkeys on Eee PC laptops.
 

  reply	other threads:[~2010-04-07 14:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-07  9:57 drivers/platform/x86/eeepc-wmi.c build error Jan III Sobieski
2010-04-07 14:22 ` Ingo Molnar [this message]
2010-04-07 15:55   ` [PATCH] eepc-wmi.c: Fix " Jan III Sobieski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100407142245.GA8714@elte.hu \
    --to=mingo@elte.hu \
    --cc=dtor@mail.ru \
    --cc=jan3sobi3ski@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mjg@redhat.com \
    --cc=yong.y.wang@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox