From: Daniel Mack <daniel@caiaq.de>
To: Dinh.Nguyen@freescale.com
Cc: linux-kernel@vger.kernel.org, amit.kucheria@canonical.com,
linux@arm.linux.org.uk, s.hauer@pengutronix.de,
grant.likely@secretlab.ca, r.herring@freescale.com,
linux-arm-kernel@lists.infradead.org, bryan.wu@canonical.com,
valentin.longchamp@epfl.ch
Subject: Re: [PATCH 2.6.34-rc4 6/8] mx5: Add USB support for Freescale MX51 Babbage
Date: Tue, 13 Apr 2010 19:40:44 +0200 [thread overview]
Message-ID: <20100413174044.GR30801@buzzloop.caiaq.de> (raw)
In-Reply-To: <1271175030-3635-6-git-send-email-Dinh.Nguyen@freescale.com>
On Tue, Apr 13, 2010 at 11:10:29AM -0500, Dinh.Nguyen@freescale.com wrote:
> This patch updates the clocks, gpios, iomuxing and device structures for
> enabling USB Host functionality on Freescale MX51 Babbage HW.
> This patch applies to 2.6.34-rc4.
>
> Signed-off-by: Dinh Nguyen <Dinh.Nguyen@freescale.com>
> ---
> arch/arm/mach-mx5/board-mx51_babbage.c | 40 +++++++++++++++++++++++++-
> arch/arm/mach-mx5/clock-mx51.c | 8 +++++
> arch/arm/mach-mx5/devices.c | 49 ++++++++++++++++++++++++++++++++
> arch/arm/mach-mx5/devices.h | 2 +
> 4 files changed, 98 insertions(+), 1 deletions(-)
That should be split in two patches - one for common code and one for
the board definition.
>
> diff --git a/arch/arm/mach-mx5/board-mx51_babbage.c b/arch/arm/mach-mx5/board-mx51_babbage.c
> index 1338d6a..ddfa48b 100644
> --- a/arch/arm/mach-mx5/board-mx51_babbage.c
> +++ b/arch/arm/mach-mx5/board-mx51_babbage.c
> @@ -13,6 +13,7 @@
> #include <linux/init.h>
> #include <linux/platform_device.h>
> #include <linux/gpio.h>
> +#include <linux/delay.h>
>
> #include <mach/common.h>
> #include <mach/hardware.h>
> @@ -30,6 +31,8 @@
> extern void __init mx5_usb_dr_init(void);
> extern void __init mx5_usbh1_init(void);
>
> +#define GPIO_1_7 (0*32+7)
> +
> static struct platform_device *devices[] __initdata = {
> &mxc_fec_device,
> };
> @@ -50,6 +53,22 @@ static struct pad_desc mx51babbage_pads[] = {
> MX51_PAD_EIM_D26__UART3_TXD,
> MX51_PAD_EIM_D27__UART3_RTS,
> MX51_PAD_EIM_D24__UART3_CTS,
> +
> + /* USB HOST1 */
> + MX51_PAD_GPIO_1_25__USBH1_CLK,
> + MX51_PAD_GPIO_1_26__USBH1_DIR,
> + MX51_PAD_GPIO_1_28__USBH1_NXT,
> + MX51_PAD_GPIO_1_11__USBH1_DATA0,
> + MX51_PAD_GPIO_1_12__USBH1_DATA1,
> + MX51_PAD_GPIO_1_13__USBH1_DATA2,
> + MX51_PAD_GPIO_1_14__USBH1_DATA3,
> + MX51_PAD_GPIO_1_15__USBH1_DATA4,
> + MX51_PAD_GPIO_1_16__USBH1_DATA5,
> + MX51_PAD_GPIO_1_17__USBH1_DATA6,
> + MX51_PAD_GPIO_1_18__USBH1_DATA7,
> +
> + /* USB HUB reset line*/
> + MX51_PAD_GPIO_1_7__GPIO1_7,
> };
>
> /* Serial ports */
> @@ -64,12 +83,31 @@ static inline void mxc_init_imx_uart(void)
> mxc_register_device(&mxc_uart_device1, &uart_pdata);
> mxc_register_device(&mxc_uart_device2, &uart_pdata);
> }
> -#else /* !SERIAL_IMX */
> +#else /* SERIAL_IMX */
> static inline void mxc_init_imx_uart(void)
> {
> }
> #endif /* SERIAL_IMX */
>
> +static inline void mx5_babbage_usbhub_reset(void)
> +{
> + int ret;
> +
> + /* Bring USB hub out of reset */
> + ret = gpio_request(GPIO_1_7, "GPIO1_7");
> + if (ret) {
> + printk("failed to get GPIO_1_7: %d\n", ret);
> + return;
> + }
> + gpio_direction_output(GPIO_1_7, 0);
> +
> + /* USB HUB RESET - De-assert USB HUB RESET_N */
> + msleep(1);
> + gpio_set_value(GPIO_1_7, 0);
> + msleep(1);
> + gpio_set_value(GPIO_1_7, 1);
> +}
> +
> /*
> * Board specific initialization.
> */
> diff --git a/arch/arm/mach-mx5/clock-mx51.c b/arch/arm/mach-mx5/clock-mx51.c
> index 8f85f73..36684d0 100644
> --- a/arch/arm/mach-mx5/clock-mx51.c
> +++ b/arch/arm/mach-mx5/clock-mx51.c
> @@ -765,6 +765,10 @@ DEFINE_CLOCK(gpt_ipg_clk, 0, MXC_CCM_CCGR2, MXC_CCM_CCGRx_CG10_OFFSET,
> DEFINE_CLOCK(fec_clk, 0, MXC_CCM_CCGR2, MXC_CCM_CCGRx_CG12_OFFSET,
> NULL, NULL, &ipg_clk, NULL);
>
> +/* USB */
> +DEFINE_CLOCK(usboh3_clk, 0, MXC_CCM_CCGR2, MXC_CCM_CCGRx_CG14_OFFSET,
> + NULL, NULL, &pll3_sw_clk, NULL);
> +
> #define _REGISTER_CLOCK(d, n, c) \
> { \
> .dev_id = d, \
> @@ -778,6 +782,10 @@ static struct clk_lookup lookups[] = {
> _REGISTER_CLOCK("imx-uart.2", NULL, uart3_clk)
> _REGISTER_CLOCK(NULL, "gpt", gpt_clk)
> _REGISTER_CLOCK("fec.0", NULL, fec_clk)
> + _REGISTER_CLOCK("mxc-ehci.0", "usb", usboh3_clk)
> + _REGISTER_CLOCK("mxc-ehci.0", "usb_ahb", ahb_clk)
> + _REGISTER_CLOCK("mxc-ehci.1", "usb", usboh3_clk)
> + _REGISTER_CLOCK("mxc-ehci.1", "usb_ahb", ahb_clk)
> };
>
> static void clk_tree_init(void)
> diff --git a/arch/arm/mach-mx5/devices.c b/arch/arm/mach-mx5/devices.c
> index 73f2342..3d8f66a 100644
> --- a/arch/arm/mach-mx5/devices.c
> +++ b/arch/arm/mach-mx5/devices.c
> @@ -11,6 +11,7 @@
> */
>
> #include <linux/platform_device.h>
> +#include <linux/dma-mapping.h>
> #include <mach/hardware.h>
> #include <mach/gpio.h>
> #include <mach/imx-uart.h>
> @@ -92,6 +93,54 @@ struct platform_device mxc_fec_device = {
> .resource = mxc_fec_resources,
> };
>
> +static u64 usb_dma_mask = DMA_BIT_MASK(32);
> +
> +static struct resource usbotg_resources[] = {
> + {
> + .start = MX51_OTG_BASE_ADDR,
> + .end = MX51_OTG_BASE_ADDR + 0x1ff,
> + .flags = IORESOURCE_MEM,
> + },
> + {
> + .start = MX51_MXC_INT_USB_OTG,
> + .flags = IORESOURCE_IRQ,
> + },
> +};
> +
> +struct platform_device mxc_usbdr_host_device = {
> + .name = "mxc-ehci",
> + .id = 0,
> + .num_resources = ARRAY_SIZE(usbotg_resources),
> + .resource = usbotg_resources,
> + .dev = {
> + .dma_mask = &usb_dma_mask,
> + .coherent_dma_mask = DMA_BIT_MASK(32),
> + },
> +};
> +
> +static struct resource usbh1_resources[] = {
> + {
> + .start = MX51_OTG_BASE_ADDR + 0x200,
> + .end = MX51_OTG_BASE_ADDR + 0x200 + 0x1ff,
> + .flags = IORESOURCE_MEM,
> + },
> + {
> + .start = MX51_MXC_INT_USB_H1,
> + .flags = IORESOURCE_IRQ,
> + },
> +};
> +
> +struct platform_device mxc_usbh1_device = {
> + .name = "mxc-ehci",
> + .id = 1,
> + .num_resources = ARRAY_SIZE(usbh1_resources),
> + .resource = usbh1_resources,
> + .dev = {
> + .dma_mask = &usb_dma_mask,
> + .coherent_dma_mask = DMA_BIT_MASK(32),
> + },
> +};
> +
> struct mxc_gpio_port mxc_gpio_ports[] = {
> {
> .chip.label = "gpio-0",
> diff --git a/arch/arm/mach-mx5/devices.h b/arch/arm/mach-mx5/devices.h
> index f339ab8..95c45f9 100644
> --- a/arch/arm/mach-mx5/devices.h
> +++ b/arch/arm/mach-mx5/devices.h
> @@ -2,3 +2,5 @@ extern struct platform_device mxc_uart_device0;
> extern struct platform_device mxc_uart_device1;
> extern struct platform_device mxc_uart_device2;
> extern struct platform_device mxc_fec_device;
> +extern struct platform_device mxc_usbdr_host_device;
> +extern struct platform_device mxc_usbh1_device;
> --
> 1.6.0.4
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2010-04-13 17:40 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-13 16:10 [PATCH 2.6.34-rc4 1/8] mx5: Add registration of GPIOs for MX51 Babbage board Dinh.Nguyen
2010-04-13 16:10 ` [PATCH 2.6.34-rc4 2/8] mxc: Update GPIO for USB support on Freescale MX51 Babbage HW Dinh.Nguyen
2010-04-13 16:10 ` [PATCH 2.6.34-rc4 3/8] mxc: Add platform specific USB functions for Freescale MX51 HW Dinh.Nguyen
2010-04-13 16:10 ` [PATCH 2.6.34-rc4 4/8] mx5: Add USB OTG port registration Dinh.Nguyen
2010-04-13 16:10 ` [PATCH 2.6.34-rc4 5/8] mx5: Add USB Host1 " Dinh.Nguyen
2010-04-13 16:10 ` [PATCH 2.6.34-rc4 6/8] mx5: Add USB support for Freescale MX51 Babbage Dinh.Nguyen
2010-04-13 16:10 ` [PATCH 2.6.34-rc4 7/8] mx5: Add USB to " Dinh.Nguyen
2010-04-14 6:33 ` Bryan Wu
2010-04-15 4:33 ` Nguyen Dinh-R00091
2010-04-13 17:40 ` Daniel Mack [this message]
2010-04-14 6:20 ` [PATCH 2.6.34-rc4 6/8] mx5: Add USB support for " Bryan Wu
2010-04-13 17:39 ` [PATCH 2.6.34-rc4 5/8] mx5: Add USB Host1 port registration Daniel Mack
2010-04-13 17:30 ` [PATCH 2.6.34-rc4 4/8] mx5: Add USB OTG " Daniel Mack
2010-04-14 6:58 ` Bryan Wu
2010-04-14 7:30 ` Daniel Mack
2010-04-13 17:27 ` [PATCH 2.6.34-rc4 3/8] mxc: Add platform specific USB functions for Freescale MX51 HW Daniel Mack
2010-04-13 16:48 ` [PATCH 2.6.34-rc4 2/8] mxc: Update GPIO for USB support on Freescale MX51 Babbage HW Daniel Mack
2010-04-14 6:34 ` Sascha Hauer
2010-04-13 16:45 ` [PATCH 2.6.34-rc4 1/8] mx5: Add registration of GPIOs for MX51 Babbage board Daniel Mack
2010-04-13 19:36 ` Nguyen Dinh-R00091
2010-04-14 6:51 ` Sascha Hauer
2010-04-14 7:31 ` Daniel Mack
2010-04-14 7:37 ` Sascha Hauer
2010-04-13 17:20 ` Sascha Hauer
2010-04-13 19:44 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100413174044.GR30801@buzzloop.caiaq.de \
--to=daniel@caiaq.de \
--cc=Dinh.Nguyen@freescale.com \
--cc=amit.kucheria@canonical.com \
--cc=bryan.wu@canonical.com \
--cc=grant.likely@secretlab.ca \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=r.herring@freescale.com \
--cc=s.hauer@pengutronix.de \
--cc=valentin.longchamp@epfl.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox