public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Dmitry Monakhov <dmonakhov@openvz.org>
Cc: linux-kernel@vger.kernel.org, jens.axboe@oracle.com, hch@infradead.org
Subject: Re: [PATCH 4/4] patch blk-add-zeroout-helper.patch
Date: Tue, 13 Apr 2010 14:07:30 -0400	[thread overview]
Message-ID: <20100413180730.GF21302@infradead.org> (raw)
In-Reply-To: <1271077437-7921-5-git-send-email-dmonakhov@openvz.org>

Looks okayish to me, but it really needs:

 a) a useful patch description
 b) patches that introduce actual users

Also why does the function have a __ prefix in the name?


  reply	other threads:[~2010-04-13 18:07 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-12 13:03 [PATCH 0/4] blkdev: blkdev_issue_fn cleanups v2 Dmitry Monakhov
2010-04-12 13:03 ` [PATCH 1/4] blkdev: pass gfp_mask and flags to blkdev_issue_flush Dmitry Monakhov
2010-04-12 13:03   ` [PATCH 2/4] blkdev: generalize flags for blkdev_issue_fn functions Dmitry Monakhov
2010-04-12 13:03     ` [PATCH 3/4] blkdev: add blkdev_issue helper functions Dmitry Monakhov
2010-04-12 13:03       ` [PATCH 4/4] patch blk-add-zeroout-helper.patch Dmitry Monakhov
2010-04-13 18:07         ` Christoph Hellwig [this message]
2010-04-13 18:06       ` [PATCH 3/4] blkdev: add blkdev_issue helper functions Christoph Hellwig
2010-04-13 18:05     ` [PATCH 2/4] blkdev: generalize flags for blkdev_issue_fn functions Christoph Hellwig
2010-04-13 18:08   ` [PATCH 1/4] blkdev: pass gfp_mask and flags to blkdev_issue_flush Christoph Hellwig
2010-04-13 18:10   ` Christoph Hellwig
2010-04-14  6:18     ` Dmitry Monakhov
2010-04-26 15:01 ` [PATCH 0/4] blkdev: blkdev_issue_fn cleanups v2 Christoph Hellwig
2010-04-26 17:26   ` Jens Axboe
2010-04-26 17:32     ` Dmitry Monakhov
2010-04-26 17:47       ` Jens Axboe
2010-04-28 13:55     ` [PATCH 0/4] blkdev: blkdev_issue_fn cleanups v3 Dmitry Monakhov
2010-04-28 13:55       ` [PATCH 1/4] blkdev: generalize flags for blkdev_issue_fn functions Dmitry Monakhov
2010-04-28 13:55         ` [PATCH 2/4] blkdev: allow async blkdev_issue_flush requests Dmitry Monakhov
2010-04-28 13:55           ` [PATCH 3/4] blkdev: move blkdev_issue helper functions to separate file Dmitry Monakhov
2010-04-28 13:55             ` [PATCH 4/4] blkdev: add blkdev_issue_zeroout helper function Dmitry Monakhov
2010-04-28 18:17       ` [PATCH 0/4] blkdev: blkdev_issue_fn cleanups v3 Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100413180730.GF21302@infradead.org \
    --to=hch@infradead.org \
    --cc=dmonakhov@openvz.org \
    --cc=jens.axboe@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox