From: Arnaldo Carvalho de Melo <acme@redhat.com>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH v3] perf: Fix accidentally preprocessed snprintf callback
Date: Wed, 14 Apr 2010 14:31:30 -0300 [thread overview]
Message-ID: <20100414173130.GJ25649@ghostprotocols.net> (raw)
In-Reply-To: <1271265089-1842-1-git-send-regression-fweisbec@gmail.com>
Em Wed, Apr 14, 2010 at 07:11:29PM +0200, Frederic Weisbecker escreveu:
> struct sort_entry has a callback named snprintf that turns an
> entry into a string result.
> But there are glibc versions that implement snprintf through a
> macro. The following expression is then going to get the snprintf
> call preprocessed:
>
> ent->snprintf(...)
>
> to finally end up in a build error:
>
> util/hist.c: Dans la fonction «hist_entry__snprintf» :
> util/hist.c:539: erreur: «struct sort_entry» has no member named «__builtin___snprintf_chk»
>
> To fix this, prepend struct sort_entry callbacks with an "se_"
> prefix.
Thanks, I'll queue this one up
- Arnaldo
prev parent reply other threads:[~2010-04-14 17:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-14 0:37 [PATCH] perf: Fix accidentally preprocessed snprintf callback Frederic Weisbecker
2010-04-14 0:41 ` Frederic Weisbecker
2010-04-14 2:28 ` Arnaldo Carvalho de Melo
2010-04-14 14:55 ` Frederic Weisbecker
2010-04-14 17:09 ` [PATCH v2] struct sort_entry has a callback named snprintf that turns an entry into a string result Frederic Weisbecker
2010-04-14 17:11 ` [PATCH v3] perf: Fix accidentally preprocessed snprintf callback Frederic Weisbecker
2010-04-14 17:31 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100414173130.GJ25649@ghostprotocols.net \
--to=acme@redhat.com \
--cc=a.p.zijlstra@chello.nl \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox