From: Jens Axboe <jens.axboe@oracle.com>
To: Richard Kennedy <richard@rsk.demon.co.uk>
Cc: lkml <linux-kernel@vger.kernel.org>,
Hannes Reinecke <hare@suse.de>, Tejun Heo <tj@kernel.org>
Subject: Re: [PATCH] block: blk-timeout.c ensure jiffies wrap is handled correctly in blk_rq_timed_out_timer
Date: Wed, 14 Apr 2010 20:52:42 +0200 [thread overview]
Message-ID: <20100414185242.GN27497@kernel.dk> (raw)
In-Reply-To: <1271242645.2132.22.camel@localhost>
On Wed, Apr 14 2010, Richard Kennedy wrote:
> blk_rq_timed_out_timer() relied on blk_add_timer() never returning a
> timer value of zero, but commit 7838c15b8dd18e78a523513749e5b54bda07b0cb
> removed the code that bumped this value when it was zero.
> Therefore when jiffies is near wrap we could get unlucky & not set the
> timeout value correctly.
>
> This patch uses a flag to indicate that the timeout value was set and so
> handles jiffies wrap correctly, and it keeps all the logic in one
> function so should be easier to maintain in the future.
Thanks applied, it also makes it a bit clearer.
--
Jens Axboe
prev parent reply other threads:[~2010-04-14 18:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-14 10:57 [PATCH] block: blk-timeout.c ensure jiffies wrap is handled correctly in blk_rq_timed_out_timer Richard Kennedy
2010-04-14 18:52 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100414185242.GN27497@kernel.dk \
--to=jens.axboe@oracle.com \
--cc=hare@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=richard@rsk.demon.co.uk \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox