From: Jason Baron <jbaron@redhat.com>
To: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
Cc: linux-kernel@vger.kernel.org, mingo@elte.hu, hpa@zytor.com,
tglx@linutronix.de, rostedt@goodmis.org, andi@firstfloor.org,
roland@redhat.com, rth@redhat.com, mhiramat@redhat.com,
fweisbec@gmail.com, avi@redhat.com
Subject: Re: [PATCH 0/9] jump label v6
Date: Wed, 14 Apr 2010 15:34:19 -0400 [thread overview]
Message-ID: <20100414193419.GC2747@redhat.com> (raw)
In-Reply-To: <20100413165659.GA23931@Krystal>
On Tue, Apr 13, 2010 at 12:56:59PM -0400, Mathieu Desnoyers wrote:
> * Jason Baron (jbaron@redhat.com) wrote:
> > Hi,
> >
> > Refresh of jump labeling patches aginst -tip tree. For bacground see:
> > http://marc.info/?l=linux-kernel&m=125858436505941&w=2
> >
> > I believe I've addressed all the reviews from v5.
>
> Hi Jason,
>
> I would appreciate if you could add pointers to the Immediate Values
> benchmarks (or possibly some benchmark information altogether) and a
> notice that some parts of the design are inspired from Immediate Values
> in the jump label code.
>
> I recognise that you did great work on getting jump label in shape both
> at the Linux kernel and gcc level, but it's usually appropriate to
> acknowledge prior work it is based on. Only then can I justify that
> Immediate Values have been useful in the whole process.
>
So I've been doing micro-benchmarks measuring the cycles involved when
the tracepoints are disabled. As quoted from the above pointer:
"As discussed in pervious mails I've seen an average improvement of 30
cycles per-tracepoint on x86_64 systems that I've tested."
I can post my test harness if you are interested.
If there are any other benchmarks of interest please let me know.
I am planning to add a Docmentation/ file for jump labels, so I can add
about the previous Immediate value work, which certainly has been
useful.
thanks,
-Jason
prev parent reply other threads:[~2010-04-14 19:35 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-09 19:49 [PATCH 0/9] jump label v6 Jason Baron
2010-04-09 19:49 ` [PATCH 1/9] jump label: notifier atomic call chain notrace Jason Baron
2010-04-09 19:49 ` [PATCH 2/9] jump label: base patch Jason Baron
2010-04-09 19:49 ` [PATCH 3/9] jump label: x86 support Jason Baron
2010-04-09 19:49 ` [PATCH 4/9] jump label: tracepoint support Jason Baron
2010-04-09 19:49 ` [PATCH 5/9] jump label: add module support Jason Baron
2010-04-09 19:49 ` [PATCH 6/9] jump label: move ftrace_dyn_arch_init to common code Jason Baron
2010-04-09 19:49 ` [PATCH 7/9] jump label: sort jump table at build-time Jason Baron
2010-04-09 21:24 ` Vivek Goyal
2010-04-09 21:32 ` Roland McGrath
2010-04-09 19:50 ` [PATCH 8/9] jump label: initialize workqueue tracepoints *before* they are registered Jason Baron
2010-04-09 19:50 ` [PATCH 9/9] jump label: jump_label_text_reserved() to reserve our jump points Jason Baron
2010-04-09 21:09 ` Masami Hiramatsu
2010-04-09 20:36 ` [PATCH 0/9] jump label v6 Masami Hiramatsu
2010-04-09 21:37 ` Jason Baron
2010-04-09 21:58 ` Masami Hiramatsu
2010-04-10 6:16 ` David Miller
2010-04-10 6:22 ` H. Peter Anvin
2010-04-13 16:56 ` Mathieu Desnoyers
2010-04-14 19:34 ` Jason Baron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100414193419.GC2747@redhat.com \
--to=jbaron@redhat.com \
--cc=andi@firstfloor.org \
--cc=avi@redhat.com \
--cc=fweisbec@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@polymtl.ca \
--cc=mhiramat@redhat.com \
--cc=mingo@elte.hu \
--cc=roland@redhat.com \
--cc=rostedt@goodmis.org \
--cc=rth@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox