From: Alan Cox <alan@linux.intel.com>
To: Jonathan Cameron <jic23@cam.ac.uk>
Cc: "Éric Piel" <E.A.B.Piel@tudelft.nl>,
linux-i2c@vger.kernel.org, khali@linux-fr.org,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] liss331d1: accelerometer driver
Date: Thu, 15 Apr 2010 11:02:32 +0100 [thread overview]
Message-ID: <20100415110232.7fc80ac1@linux.intel.com> (raw)
In-Reply-To: <4BC6EA64.4070308@cam.ac.uk>
> Err. Anyone get a feeling of deja vu here?
>
> http://lists.lm-sensors.org/pipermail/lm-sensors/2009-September/026706.html
>
> When Kalhan originally posted this driver it was pointed out that it
> was compatible with the existing one. A complete lack of
> communications lead to Kalhan (and someone else, might have been Eric
> or Samu, can't recall) both implementing i2c support in the driver.
> Can't find it right now but I'm fairly sure Kahlan reported that
> worked fine for this chip as well?
>
> So looks like a lack of communications here and that Alan has picked
> up an unnecessary driver.
Thanks it does indeed - except for the retry logic which has come from
another platform source and can be submitted in turn. Only other thing I
see odd is that the existing driver prints a scary error message when
there is no IRQ rather than just an info message.
Alan
next prev parent reply other threads:[~2010-04-15 10:35 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-14 12:51 [PATCH 0/4] Various intel small device drivers Alan Cox
2010-04-14 12:51 ` [PATCH 1/4] hmc6352: Add driver for the HMC6352 compass Alan Cox
2010-04-14 13:48 ` Jonathan Cameron
2010-04-14 14:32 ` Alan Cox
2010-04-14 14:51 ` Jonathan Cameron
2010-04-14 15:19 ` Alan Cox
2010-04-14 16:39 ` Jonathan Cameron
2010-04-14 21:36 ` Joe Perches
2010-04-15 12:11 ` Alan Cox
2010-04-15 15:57 ` Joe Perches
2010-04-14 16:56 ` isl29020: ALS driver as misc device Alan Cox
2010-04-14 17:01 ` Greg KH
2010-04-15 10:09 ` Jonathan Cameron
2010-04-15 11:17 ` Alan Cox
2010-04-26 10:59 ` Jonathan Cameron
2010-04-14 12:51 ` [PATCH 2/4] isl29020: ambient light sensor Alan Cox
2010-04-14 22:45 ` Daniel Mack
2010-04-14 22:35 ` Alan Cox
2010-04-15 6:20 ` Daniel Mack
2010-04-15 10:15 ` Jonathan Cameron
2010-04-14 12:52 ` [PATCH 3/4] liss331d1: accelerometer driver Alan Cox
2010-04-14 22:12 ` Éric Piel
2010-04-14 22:34 ` Daniel Mack
2010-04-14 23:05 ` Neil Brown
2010-04-15 9:47 ` Éric Piel
2010-04-14 22:37 ` Alan Cox
2010-04-15 10:28 ` Jonathan Cameron
2010-04-15 10:02 ` Alan Cox [this message]
2010-04-15 19:12 ` Pavel Machek
2010-04-14 12:52 ` [PATCH 4/4] emc1403: thermal sensor support Alan Cox
2010-04-14 13:30 ` [PATCH 0/4] Various intel small device drivers Jean Delvare
2010-04-14 13:49 ` Alan Cox
2010-04-14 13:55 ` Jonathan Cameron
2010-04-14 14:19 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100415110232.7fc80ac1@linux.intel.com \
--to=alan@linux.intel.com \
--cc=E.A.B.Piel@tudelft.nl \
--cc=jic23@cam.ac.uk \
--cc=khali@linux-fr.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox