From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752851Ab0DPFWv (ORCPT ); Fri, 16 Apr 2010 01:22:51 -0400 Received: from ksp.mff.cuni.cz ([195.113.26.206]:42284 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752254Ab0DPFWu (ORCPT ); Fri, 16 Apr 2010 01:22:50 -0400 Date: Thu, 15 Apr 2010 21:12:18 +0200 From: Pavel Machek To: Takashi Iwai Cc: Dmitry Torokhov , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] input: Add LED support to Synaptics device Message-ID: <20100415191217.GA1495@ucw.cz> References: <1271257823-23566-1-git-send-email-tiwai@suse.de> <1271257823-23566-3-git-send-email-tiwai@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1271257823-23566-3-git-send-email-tiwai@suse.de> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi! > The new Synaptics devices have an LED on the top-left corner. > This is controlled via the command 0x0a with parameters 0x88 or 0x10. > > The detection of the LED isn't clear yet. It should have been the new > capability bits that indicate the presence, but on real machines, it > doesn't fit. So, for the time being, the driver checks the product id > in the ext capability bits and assumes that LED exists on the known > devices. > > The support of LED is controlled via a normal input event with EV_LED > bit mask. It supports LED_MUTE bit. X driver can detect the LED > support by checking these bits. Could we use generic LED API for this? It is not really 'mute' led after all... Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html