From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753230Ab0DPF3w (ORCPT ); Fri, 16 Apr 2010 01:29:52 -0400 Received: from mail-gw0-f46.google.com ([74.125.83.46]:50946 "EHLO mail-gw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752768Ab0DPF3u (ORCPT ); Fri, 16 Apr 2010 01:29:50 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; b=Ji69gEmyQzmTwtSEm9kJXLIrqopJ1sxFKomI0kzCsCDyw+Y+2j5BWKiNnALdUCuNi7 f6frjCSa0Y3+ocHecgZdDC3ZntSDNbdtUqKVlY5OLGuD0bFF+Ps9bY3ue3O+7gBjtvDd ojFGnrWL5SOZHahmzT9JUEXcSo4MPR16Fr7pI= Date: Thu, 15 Apr 2010 22:29:44 -0700 From: Dmitry Torokhov To: Pavel Machek Cc: Takashi Iwai , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] input: Add LED support to Synaptics device Message-ID: <20100416052944.GB1078@core.coreip.homeip.net> References: <1271257823-23566-1-git-send-email-tiwai@suse.de> <1271257823-23566-3-git-send-email-tiwai@suse.de> <20100415191217.GA1495@ucw.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100415191217.GA1495@ucw.cz> User-Agent: Mutt/1.5.20 (2009-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 15, 2010 at 09:12:18PM +0200, Pavel Machek wrote: > Hi! > > > The new Synaptics devices have an LED on the top-left corner. > > This is controlled via the command 0x0a with parameters 0x88 or 0x10. > > > > The detection of the LED isn't clear yet. It should have been the new > > capability bits that indicate the presence, but on real machines, it > > doesn't fit. So, for the time being, the driver checks the product id > > in the ext capability bits and assumes that LED exists on the known > > devices. > > > > The support of LED is controlled via a normal input event with EV_LED > > bit mask. It supports LED_MUTE bit. X driver can detect the LED > > support by checking these bits. > > Could we use generic LED API for this? It is not really 'mute' led > after all... Yep, LED_MUTE is not for "muting" touchpads. -- Dmitry