* [PATCH] blkio: Initialize blkg->stats_lock for the root cfqg too
@ 2010-04-16 4:02 Divyesh Shah
2010-04-16 4:19 ` Gui Jianfeng
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Divyesh Shah @ 2010-04-16 4:02 UTC (permalink / raw)
To: jens.axboe, guijianfeng, vgoyal; +Cc: linux-kernel, lizf
This fixes the lockdep warning reported by Gui Jianfeng.
Signed-off-by: Divyesh Shah <dpshah@google.com>
---
block/blk-cgroup.c | 7 +------
block/blk-cgroup.h | 2 --
block/cfq-iosched.c | 1 -
3 files changed, 1 insertions(+), 9 deletions(-)
diff --git a/block/blk-cgroup.c b/block/blk-cgroup.c
index 80c1261..83930f6 100644
--- a/block/blk-cgroup.c
+++ b/block/blk-cgroup.c
@@ -86,12 +86,6 @@ struct blkio_cgroup *cgroup_to_blkio_cgroup(struct cgroup *cgroup)
}
EXPORT_SYMBOL_GPL(cgroup_to_blkio_cgroup);
-void blkio_group_init(struct blkio_group *blkg)
-{
- spin_lock_init(&blkg->stats_lock);
-}
-EXPORT_SYMBOL_GPL(blkio_group_init);
-
/*
* Add to the appropriate stat variable depending on the request type.
* This should be called with the blkg->stats_lock held.
@@ -349,6 +343,7 @@ void blkiocg_add_blkio_group(struct blkio_cgroup *blkcg,
unsigned long flags;
spin_lock_irqsave(&blkcg->lock, flags);
+ spin_lock_init(&blkg->stats_lock);
rcu_assign_pointer(blkg->key, key);
blkg->blkcg_id = css_id(&blkcg->css);
hlist_add_head_rcu(&blkg->blkcg_node, &blkcg->blkg_list);
diff --git a/block/blk-cgroup.h b/block/blk-cgroup.h
index 1d409ad..2c956a0 100644
--- a/block/blk-cgroup.h
+++ b/block/blk-cgroup.h
@@ -217,7 +217,6 @@ extern void blkiocg_add_blkio_group(struct blkio_cgroup *blkcg,
extern int blkiocg_del_blkio_group(struct blkio_group *blkg);
extern struct blkio_group *blkiocg_lookup_group(struct blkio_cgroup *blkcg,
void *key);
-void blkio_group_init(struct blkio_group *blkg);
void blkiocg_update_timeslice_used(struct blkio_group *blkg,
unsigned long time);
void blkiocg_update_dispatch_stats(struct blkio_group *blkg, uint64_t bytes,
@@ -235,7 +234,6 @@ struct cgroup;
static inline struct blkio_cgroup *
cgroup_to_blkio_cgroup(struct cgroup *cgroup) { return NULL; }
-static inline void blkio_group_init(struct blkio_group *blkg) {}
static inline void blkiocg_add_blkio_group(struct blkio_cgroup *blkcg,
struct blkio_group *blkg, void *key, dev_t dev) {}
diff --git a/block/cfq-iosched.c b/block/cfq-iosched.c
index 0177109..62defd0 100644
--- a/block/cfq-iosched.c
+++ b/block/cfq-iosched.c
@@ -961,7 +961,6 @@ cfq_find_alloc_cfqg(struct cfq_data *cfqd, struct cgroup *cgroup, int create)
for_each_cfqg_st(cfqg, i, j, st)
*st = CFQ_RB_ROOT;
RB_CLEAR_NODE(&cfqg->rb_node);
- blkio_group_init(&cfqg->blkg);
/*
* Take the initial reference that will be released on destroy
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] blkio: Initialize blkg->stats_lock for the root cfqg too
2010-04-16 4:02 [PATCH] blkio: Initialize blkg->stats_lock for the root cfqg too Divyesh Shah
@ 2010-04-16 4:19 ` Gui Jianfeng
2010-04-16 6:07 ` Jens Axboe
2010-04-16 13:18 ` Vivek Goyal
2 siblings, 0 replies; 4+ messages in thread
From: Gui Jianfeng @ 2010-04-16 4:19 UTC (permalink / raw)
To: Divyesh Shah, jens.axboe; +Cc: vgoyal, linux-kernel, lizf
Divyesh Shah wrote:
> This fixes the lockdep warning reported by Gui Jianfeng.
>
> Signed-off-by: Divyesh Shah <dpshah@google.com>
This patch looks good to me.
Reviewed-by: Gui Jianfeng <guijianfeng@cn.fujitsu.com>
> ---
>
> block/blk-cgroup.c | 7 +------
> block/blk-cgroup.h | 2 --
> block/cfq-iosched.c | 1 -
> 3 files changed, 1 insertions(+), 9 deletions(-)
>
> diff --git a/block/blk-cgroup.c b/block/blk-cgroup.c
> index 80c1261..83930f6 100644
> --- a/block/blk-cgroup.c
> +++ b/block/blk-cgroup.c
> @@ -86,12 +86,6 @@ struct blkio_cgroup *cgroup_to_blkio_cgroup(struct cgroup *cgroup)
> }
> EXPORT_SYMBOL_GPL(cgroup_to_blkio_cgroup);
>
> -void blkio_group_init(struct blkio_group *blkg)
> -{
> - spin_lock_init(&blkg->stats_lock);
> -}
> -EXPORT_SYMBOL_GPL(blkio_group_init);
> -
> /*
> * Add to the appropriate stat variable depending on the request type.
> * This should be called with the blkg->stats_lock held.
> @@ -349,6 +343,7 @@ void blkiocg_add_blkio_group(struct blkio_cgroup *blkcg,
> unsigned long flags;
>
> spin_lock_irqsave(&blkcg->lock, flags);
> + spin_lock_init(&blkg->stats_lock);
> rcu_assign_pointer(blkg->key, key);
> blkg->blkcg_id = css_id(&blkcg->css);
> hlist_add_head_rcu(&blkg->blkcg_node, &blkcg->blkg_list);
> diff --git a/block/blk-cgroup.h b/block/blk-cgroup.h
> index 1d409ad..2c956a0 100644
> --- a/block/blk-cgroup.h
> +++ b/block/blk-cgroup.h
> @@ -217,7 +217,6 @@ extern void blkiocg_add_blkio_group(struct blkio_cgroup *blkcg,
> extern int blkiocg_del_blkio_group(struct blkio_group *blkg);
> extern struct blkio_group *blkiocg_lookup_group(struct blkio_cgroup *blkcg,
> void *key);
> -void blkio_group_init(struct blkio_group *blkg);
> void blkiocg_update_timeslice_used(struct blkio_group *blkg,
> unsigned long time);
> void blkiocg_update_dispatch_stats(struct blkio_group *blkg, uint64_t bytes,
> @@ -235,7 +234,6 @@ struct cgroup;
> static inline struct blkio_cgroup *
> cgroup_to_blkio_cgroup(struct cgroup *cgroup) { return NULL; }
>
> -static inline void blkio_group_init(struct blkio_group *blkg) {}
> static inline void blkiocg_add_blkio_group(struct blkio_cgroup *blkcg,
> struct blkio_group *blkg, void *key, dev_t dev) {}
>
> diff --git a/block/cfq-iosched.c b/block/cfq-iosched.c
> index 0177109..62defd0 100644
> --- a/block/cfq-iosched.c
> +++ b/block/cfq-iosched.c
> @@ -961,7 +961,6 @@ cfq_find_alloc_cfqg(struct cfq_data *cfqd, struct cgroup *cgroup, int create)
> for_each_cfqg_st(cfqg, i, j, st)
> *st = CFQ_RB_ROOT;
> RB_CLEAR_NODE(&cfqg->rb_node);
> - blkio_group_init(&cfqg->blkg);
>
> /*
> * Take the initial reference that will be released on destroy
>
>
>
>
--
Regards
Gui Jianfeng
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] blkio: Initialize blkg->stats_lock for the root cfqg too
2010-04-16 4:02 [PATCH] blkio: Initialize blkg->stats_lock for the root cfqg too Divyesh Shah
2010-04-16 4:19 ` Gui Jianfeng
@ 2010-04-16 6:07 ` Jens Axboe
2010-04-16 13:18 ` Vivek Goyal
2 siblings, 0 replies; 4+ messages in thread
From: Jens Axboe @ 2010-04-16 6:07 UTC (permalink / raw)
To: Divyesh Shah; +Cc: guijianfeng, vgoyal, linux-kernel, lizf
On Thu, Apr 15 2010, Divyesh Shah wrote:
> This fixes the lockdep warning reported by Gui Jianfeng.
Thanks, applied.
--
Jens Axboe
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] blkio: Initialize blkg->stats_lock for the root cfqg too
2010-04-16 4:02 [PATCH] blkio: Initialize blkg->stats_lock for the root cfqg too Divyesh Shah
2010-04-16 4:19 ` Gui Jianfeng
2010-04-16 6:07 ` Jens Axboe
@ 2010-04-16 13:18 ` Vivek Goyal
2 siblings, 0 replies; 4+ messages in thread
From: Vivek Goyal @ 2010-04-16 13:18 UTC (permalink / raw)
To: Divyesh Shah; +Cc: jens.axboe, guijianfeng, linux-kernel, lizf
On Thu, Apr 15, 2010 at 09:02:22PM -0700, Divyesh Shah wrote:
> This fixes the lockdep warning reported by Gui Jianfeng.
>
> Signed-off-by: Divyesh Shah <dpshah@google.com>
> ---
This looks good.
Acked-by: Vivek Goyal <vgoyal@redhat.com>
Vivek
>
> block/blk-cgroup.c | 7 +------
> block/blk-cgroup.h | 2 --
> block/cfq-iosched.c | 1 -
> 3 files changed, 1 insertions(+), 9 deletions(-)
>
> diff --git a/block/blk-cgroup.c b/block/blk-cgroup.c
> index 80c1261..83930f6 100644
> --- a/block/blk-cgroup.c
> +++ b/block/blk-cgroup.c
> @@ -86,12 +86,6 @@ struct blkio_cgroup *cgroup_to_blkio_cgroup(struct cgroup *cgroup)
> }
> EXPORT_SYMBOL_GPL(cgroup_to_blkio_cgroup);
>
> -void blkio_group_init(struct blkio_group *blkg)
> -{
> - spin_lock_init(&blkg->stats_lock);
> -}
> -EXPORT_SYMBOL_GPL(blkio_group_init);
> -
> /*
> * Add to the appropriate stat variable depending on the request type.
> * This should be called with the blkg->stats_lock held.
> @@ -349,6 +343,7 @@ void blkiocg_add_blkio_group(struct blkio_cgroup *blkcg,
> unsigned long flags;
>
> spin_lock_irqsave(&blkcg->lock, flags);
> + spin_lock_init(&blkg->stats_lock);
> rcu_assign_pointer(blkg->key, key);
> blkg->blkcg_id = css_id(&blkcg->css);
> hlist_add_head_rcu(&blkg->blkcg_node, &blkcg->blkg_list);
> diff --git a/block/blk-cgroup.h b/block/blk-cgroup.h
> index 1d409ad..2c956a0 100644
> --- a/block/blk-cgroup.h
> +++ b/block/blk-cgroup.h
> @@ -217,7 +217,6 @@ extern void blkiocg_add_blkio_group(struct blkio_cgroup *blkcg,
> extern int blkiocg_del_blkio_group(struct blkio_group *blkg);
> extern struct blkio_group *blkiocg_lookup_group(struct blkio_cgroup *blkcg,
> void *key);
> -void blkio_group_init(struct blkio_group *blkg);
> void blkiocg_update_timeslice_used(struct blkio_group *blkg,
> unsigned long time);
> void blkiocg_update_dispatch_stats(struct blkio_group *blkg, uint64_t bytes,
> @@ -235,7 +234,6 @@ struct cgroup;
> static inline struct blkio_cgroup *
> cgroup_to_blkio_cgroup(struct cgroup *cgroup) { return NULL; }
>
> -static inline void blkio_group_init(struct blkio_group *blkg) {}
> static inline void blkiocg_add_blkio_group(struct blkio_cgroup *blkcg,
> struct blkio_group *blkg, void *key, dev_t dev) {}
>
> diff --git a/block/cfq-iosched.c b/block/cfq-iosched.c
> index 0177109..62defd0 100644
> --- a/block/cfq-iosched.c
> +++ b/block/cfq-iosched.c
> @@ -961,7 +961,6 @@ cfq_find_alloc_cfqg(struct cfq_data *cfqd, struct cgroup *cgroup, int create)
> for_each_cfqg_st(cfqg, i, j, st)
> *st = CFQ_RB_ROOT;
> RB_CLEAR_NODE(&cfqg->rb_node);
> - blkio_group_init(&cfqg->blkg);
>
> /*
> * Take the initial reference that will be released on destroy
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-04-16 13:18 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-04-16 4:02 [PATCH] blkio: Initialize blkg->stats_lock for the root cfqg too Divyesh Shah
2010-04-16 4:19 ` Gui Jianfeng
2010-04-16 6:07 ` Jens Axboe
2010-04-16 13:18 ` Vivek Goyal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox