From: Daniel Mack <daniel@caiaq.de>
To: Jakob Viketoft <jakob.viketoft@bitsim.com>
Cc: linux-kernel@vger.kernel.org, Eric Miao <eric.y.miao@gmail.com>
Subject: Re: [PATCH] colibri.h: Fix building for colibri 270...
Date: Fri, 16 Apr 2010 13:28:20 +0200 [thread overview]
Message-ID: <20100416112820.GM30801@buzzloop.caiaq.de> (raw)
In-Reply-To: <4BC8493D.60900@bitsim.com>
On Fri, Apr 16, 2010 at 01:25:49PM +0200, Jakob Viketoft wrote:
> Jakob Viketoft wrote:
> >Daniel Mack wrote:
> <...>
> > CC drivers/pcmcia/pxa2xx_colibri.o
> >In file included from drivers/pcmcia/pxa2xx_colibri.c:25:
> >arch/arm/mach-pxa/include/mach/colibri.h:13: error: expected ')'
> >before '*' token
> >make[2]: *** [drivers/pcmcia/pxa2xx_colibri.o] Error 1
> >make[1]: *** [drivers/pcmcia] Error 2
> >make: *** [drivers] Error 2
>
> Adding a "#include <mach/mfp.h>" seem to cure this problem. If you
> agree I can supply a new patch with the correct solution this time.
Ok. Add it to colibri.h, and while at it, you can kick the ax88796.h
inclusion. That's a leftover and isn't needed.
Thanks,
Daniel
next prev parent reply other threads:[~2010-04-16 11:28 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-16 9:51 [PATCH] colibri.h: Fix building for colibri 270 Jakob Viketoft
2010-04-16 10:01 ` Daniel Mack
2010-04-16 11:17 ` Jakob Viketoft
2010-04-16 11:25 ` Jakob Viketoft
2010-04-16 11:28 ` Daniel Mack [this message]
2010-04-16 11:29 ` Daniel Mack
2010-05-05 7:45 ` Eric Miao
2010-05-05 8:00 ` Daniel Mack
2010-05-05 9:28 ` Eric Miao
2010-05-05 9:44 ` Daniel Mack
2010-05-05 9:47 ` Eric Miao
2010-05-05 9:53 ` Daniel Mack
2010-05-05 10:21 ` Eric Miao
2010-05-05 11:02 ` Jakob Viketoft
2010-05-05 15:20 ` Greg KH
2010-05-05 15:54 ` Daniel Mack
2010-05-05 16:15 ` Greg KH
2010-04-16 11:26 ` Daniel Mack
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100416112820.GM30801@buzzloop.caiaq.de \
--to=daniel@caiaq.de \
--cc=eric.y.miao@gmail.com \
--cc=jakob.viketoft@bitsim.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox