From: Ingo Molnar <mingo@elte.hu>
To: David Miller <davem@davemloft.net>, Tilman Schmidt <tilman@imap.cc>
Cc: torvalds@linux-foundation.org, akpm@linux-foundation.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: tip: origin tree build failure, [patch] fix isdn/gigaset build failure
Date: Mon, 19 Apr 2010 19:27:31 +0200 [thread overview]
Message-ID: <20100419172731.GA4358@elte.hu> (raw)
In-Reply-To: <20100419.003857.260094283.davem@davemloft.net>
* David Miller <davem@davemloft.net> wrote:
> Tilman Schmidt (1):
> gigaset: include cleanup cleanup
>
> drivers/isdn/gigaset/bas-gigaset.c | 5 -----
> drivers/isdn/gigaset/capi.c | 2 --
> drivers/isdn/gigaset/common.c | 2 --
> drivers/isdn/gigaset/gigaset.h | 2 +-
> drivers/isdn/gigaset/i4l.c | 1 -
> drivers/isdn/gigaset/interface.c | 1 -
> drivers/isdn/gigaset/proc.c | 1 -
> drivers/isdn/gigaset/ser-gigaset.c | 3 ---
> drivers/isdn/gigaset/usb-gigaset.c | 4 ----
-tip testing triggered the following build failure (x86 allyesconfig):
drivers/isdn/gigaset/common.c: In function 'setflags':
drivers/isdn/gigaset/common.c:99: error: implicit declaration of function 'set_current_state'
drivers/isdn/gigaset/common.c:99: error: 'TASK_INTERRUPTIBLE' undeclared (first use in this function)
drivers/isdn/gigaset/common.c:99: error: (Each undeclared identifier is reported only once
drivers/isdn/gigaset/common.c:99: error: for each function it appears in.)
drivers/isdn/gigaset/common.c:100: error: implicit declaration of function 'schedule_timeout'
drivers/isdn/gigaset/common.c: In function 'cleanup_cs':
drivers/isdn/gigaset/common.c:900: error: 'TASK_INTERRUPTIBLE' undeclared (first use in this function)
drivers/isdn/gigaset/common.c: In function 'gigaset_start':
drivers/isdn/gigaset/common.c:942: error: 'TASK_UNINTERRUPTIBLE' undeclared (first use in this function)
drivers/isdn/gigaset/common.c:942: error: implicit declaration of function 'schedule'
drivers/isdn/gigaset/common.c: In function 'gigaset_shutdown':
drivers/isdn/gigaset/common.c:978: error: 'TASK_UNINTERRUPTIBLE' undeclared (first use in this function)
drivers/isdn/gigaset/common.c: In function 'gigaset_stop':
drivers/isdn/gigaset/common.c:1005: error: 'TASK_UNINTERRUPTIBLE' undeclared (first use in this function)
make[1]: *** [drivers/isdn/gigaset/common.o] Error 1
make: *** [drivers/isdn/gigaset/common.o] Error 2
Introduced by commit b91ecb00 that got pushed out today. That change removed
an implicit sched.h inclusion that came in via slab.h.
The patch below fixes it by adding the sched.h dependency.
Ingo
diff --git a/drivers/isdn/gigaset/common.c b/drivers/isdn/gigaset/common.c
index f6f45f2..a3aa17f 100644
--- a/drivers/isdn/gigaset/common.c
+++ b/drivers/isdn/gigaset/common.c
@@ -16,6 +16,7 @@
#include "gigaset.h"
#include <linux/module.h>
#include <linux/moduleparam.h>
+#include <linux/sched.h>
/* Version Information */
#define DRIVER_AUTHOR "Hansjoerg Lipp <hjlipp@web.de>, Tilman Schmidt <tilman@imap.cc>, Stefan Eilers"
next prev parent reply other threads:[~2010-04-19 17:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-19 7:38 [GIT]: Networking David Miller
2010-04-19 17:27 ` Ingo Molnar [this message]
2010-04-19 17:33 ` tip: origin tree build failure, [patch] fix isdn/gigaset build failure David Miller
2010-04-19 18:05 ` Ingo Molnar
2010-04-19 18:14 ` Linus Torvalds
2010-04-19 19:00 ` Linus Torvalds
2010-04-19 19:06 ` David Miller
2010-04-19 21:01 ` Ingo Molnar
2010-04-19 19:54 ` Ingo Molnar
2010-04-19 21:52 ` Tilman Schmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100419172731.GA4358@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tilman@imap.cc \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox