From: Christoph Hellwig <hch@lst.de>
To: torvalds@linux-foundation.org
Cc: Andy Isaacson <adi@hexapodia.org>,
akpm@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: [PATCH] x86: correctly wire up the newuname system call
Date: Tue, 20 Apr 2010 05:31:02 +0200 [thread overview]
Message-ID: <20100420033102.GA13406@lst.de> (raw)
Before commit e28cbf22933d0c0ccaf3c4c27a1a263b41f73859 64-bit x86 had
a private implementation of sys_uname which was just called sys_uname,
which other architectures used for the old uname. Due to some merge
issues with the uname refactoring patches we ended up calling the
old uname version for both the old and new system call slots, which
lead to the domainname filed never be set which caused failures with
libnss_nis.
Reported-by: Andy Isaacson <adi@hexapodia.org>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Index: linux-2.6/arch/x86/ia32/ia32entry.S
===================================================================
--- linux-2.6.orig/arch/x86/ia32/ia32entry.S 2010-04-19 20:21:11.919003961 -0700
+++ linux-2.6/arch/x86/ia32/ia32entry.S 2010-04-19 20:21:19.902005565 -0700
@@ -626,7 +626,7 @@ ia32_sys_call_table:
.quad stub32_sigreturn
.quad stub32_clone /* 120 */
.quad sys_setdomainname
- .quad sys_uname
+ .quad sys_newuname
.quad sys_modify_ldt
.quad compat_sys_adjtimex
.quad sys32_mprotect /* 125 */
next reply other threads:[~2010-04-20 3:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-20 3:31 Christoph Hellwig [this message]
2010-04-20 14:50 ` [PATCH] x86: correctly wire up the newuname system call Andy Isaacson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100420033102.GA13406@lst.de \
--to=hch@lst.de \
--cc=adi@hexapodia.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox